Closed Bug 1826927 Opened 2 years ago Closed 1 month ago

JS demo (https://www.fxhash.xyz/generative/slug/sweet-dreams) periodically spends 100ms+ in GCSlice

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: mayankleoboy1, Unassigned)

References

(Blocks 1 open bug, )

Details

Go to https://www.fxhash.xyz/generative/slug/sweet-dreams
Click on run

Profile: https://share.firefox.dev/3ZJ0z3f
Chrome doesnt have any visual janks.

Maybe some things to improve here?

Component: JavaScript Engine → JavaScript: GC
Severity: -- → N/A
Priority: -- → P3

(In reply to Mayank Bansal from comment #1)
It's not in the regression range but close by - could this be due to bug 1434542?

Latest profile. Still periodic janks
https://share.firefox.dev/3OfpEQq

And profile from the try build of bug 1875455: https://share.firefox.dev/3UdRTTd

Profile with latest Nightly: https://share.firefox.dev/3whOl8O

In the latest profile 38% of GC time is spent in jemalloc free, 75% of that poisoning memory with memset.

What's happening is that we're finishing the GC non-incrementally because of the volume of malloc allocations. What's supposed to happen is that we trigger slices more aggressively before we get to this point. I don't know why that's not happening.

This is what I get now: https://share.firefox.dev/40pDi8G
Calling this fixed.

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.