Closed
Bug 1826946
Opened 1 year ago
Closed 11 months ago
Delay frecency calculations for history batch inserts
Categories
(Toolkit :: Places, task, P3)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: perf, Whiteboard: [snt-scrubbed])
Attachments
(3 files)
It makes sense to calculate frecency immediately while the user is browsing, or for small inserts, so the urlbar will react faster to insertions... though large inserts from Migration or Sync would be ok with delayed calculation. We can avoid expensive calculation work when doing those inserts.
|
Assignee | |
Comment 1•11 months ago
|
||
|
|
Assignee | |
Comment 2•11 months ago
|
||
Depends on D179261
|
|
Assignee | |
Comment 3•11 months ago
|
||
Depends on D179262
|
|
Assignee | |
Updated•11 months ago
|
Summary: Consider delaying frecency calculation for history batch inserts → Delay frecency calculations for history batch inserts
|
||
Updated•11 months ago
|
Assignee: nobody → mak
Attachment #9336192 -
Attachment description: WIP: Bug 1826946 - rename shouldUpdateFrecency to isUnrecoverableError → Bug 1826946 - rename shouldUpdateFrecency to isUnrecoverableError. r=daisuke
Status: NEW → ASSIGNED
|
|
||
Updated•11 months ago
|
Attachment #9336193 -
Attachment description: WIP: Bug 1826946 - remove shouldUpdateHidden → Bug 1826946 - remove shouldUpdateHidden. r=daisuke
|
|
||
Updated•11 months ago
|
Attachment #9336194 -
Attachment description: WIP: Bug 1826946 - Delay frecency calculation for history batch inserts → Bug 1826946 - Delay frecency calculation for history batch inserts. r=daisuke
|
|
Assignee | |
Updated•11 months ago
|
|
||
Updated•11 months ago
|
Whiteboard: [snt-scrubbed]
|
||
Updated•11 months ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SNT-731
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/5e379963d6c6 rename shouldUpdateFrecency to isUnrecoverableError. r=daisuke https://hg.mozilla.org/integration/autoland/rev/23cd0ad9fd0a remove shouldUpdateHidden. r=daisuke https://hg.mozilla.org/integration/autoland/rev/b34dc8f7157a Delay frecency calculation for history batch inserts. r=daisuke
|
||
Comment 5•11 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5e379963d6c6
https://hg.mozilla.org/mozilla-central/rev/23cd0ad9fd0a
https://hg.mozilla.org/mozilla-central/rev/b34dc8f7157a
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
|
|
Assignee | |
Updated•11 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•