1826952 - The `Login and passwords` option is not correctly arranged inside Choose What to Sync window

Status: VERIFIED FIXED

(Core :: Layout: Flexbox, defect)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: image.png

Found in

• 113.0a1 (2023-04-07)

Affected versions

• 113.0a1 (2023-04-07)

Tested platforms

• Affected platforms: Windows 10x64, Ubuntu 20.04, macOS 12
• Unaffected platforms: none

Steps to reproduce

1. Sign in to sync and open about:preferences#sync.
2. Click on the Change button and observe Logins and passwords.

Expected result

• The logins and passwords option is correctly displayed.

Actual result

• The logins and passwords option is not correctly displayed.

Regression range

• Last good revision: a5e0bf1c32f05bf8ca038ae759569742d565a20d
  First bad revision: 6064a73fc99f012a7400393bdc2ade89fbdf30f8
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a5e0bf1c32f05bf8ca038ae759569742d565a20d&tochange=6064a73fc99f012a7400393bdc2ade89fbdf30f8
  Potential regressor: bug 1743890.

Additional notes

• Attached a screenshot.
• On Ubuntu the Logins and password option is differently positioned but still not as expected. Resizing the Choose What to Sync window will reproduce the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:TYLin, since you are the author of the regressor, bug 1743890, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Screenshot on macOS (Nightly 2023-04-07)

From the screenshot in comment 0, the bug seems to be that the "Logins and Password" option is broken into two lines and "Addresses" option is missing.

However, I failed to reproduce this bug on both MacOS and Linux, with Nightly 2023-04-07. I've tried to resizing the Choose What to Sync window. I wonder if this bug requires something else to reproduce. (Attached a screenshot on my macOS.)

Comment 3

[Alexandru Trif, Desktop QA [:atrif]]

(In reply to Ting-Yu Lin [:TYLin] (UTC-8) from comment #2)

Created attachment 9327631 [details]
Screenshot on macOS (Nightly 2023-04-07)

From the screenshot in comment 0, the bug seems to be that the "Logins and Password" option is broken into two lines and "Addresses" option is missing.

However, I failed to reproduce this bug on both MacOS and Linux, with Nightly 2023-04-07. I've tried to resizing the Choose What to Sync window. I wonder if this bug requires something else to reproduce. (Attached a screenshot on my macOS.)

After looking into this it seems that the Addresses option visibility is controlled by the services.sync.engine.addresses.available pref. Turning this preference to false and reopening the Choose What to Sync window will reproduce the issue, at least in my case.

From what I see now when I open Nightly with a new profile the services.sync.engine.addresses.available pref is modified to true (issue not reproducible if all options are displayed), but has the default value false. On my main Nightly profile that preference is false as well. Idk why this preference was false when I initially made the regression range for this issue on my FXA test account. Maybe that preference was set to false in the past on my FXA account and was synced on login.
If more information is needed please let me know. Thank you!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1743890

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1826952 - Prevent long sync engine names from breaking cross columns.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox113 (beta). However, the bug still has low severity.

:fgriffith, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 9328078 [details]
Bug 1826952 - Prevent long sync engine names from breaking cross columns.

Beta/Release Uplift Approval Request

• User impact if declined: The "Log in and passwords" UI is broken in "Choose What to Sync window" if declined.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0 and comment 3 for the steps.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a one line CSS change in Chrome UI.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07aa1efdf65f
Prevent long sync engine names from breaking cross columns. r=settings-reviewers,Gijs

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/07aa1efdf65f

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9328078 [details]
Bug 1826952 - Prevent long sync engine names from breaking cross columns.

Approved for 113 beta 3, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/d154f5e0bbee

Comment 12

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 114.0a1 (2023-04-18) and 113.0b5 on Windows 10x64, macOS 12 and Ubuntu 20.04. The Login and passwords option is correctly arranged inside Choose What to Sync after following the steps from comment 0 and comment 3.