1826954 - Enable http3 devtools browser mochitests

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task)

Description

[Julian Descottes [:jdescottes]]

We added a first devtools mochitest relying on http3 being enabled for browser mochitests in Bug 1825916.

However the devtools test suite has overall too many failures in order to simply add a http3 variant for devtools mochitests.

This bug is meant to investigate how many test suites need to be disabled/modified in order to be able to create a http3 devtools variant.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1826954 - Support example.net for http3 browser mochitests

Comment 2

[Julian Descottes [:jdescottes]]

I can see that example.net is not listed in the certificate needed for http3, which probably triggers a lot of failures for devtools. Let's see if adding it helps significantly: https://treeherder.mozilla.org/jobs?repo=try&revision=45933c71c0f58d0162f33b36df437cc2c338b20b

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1826954 - [devtools] Always read response protocol to fetch http version

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1826954 - [devtools] Disable devtools tests and test suites failing with http3

Depends on D174958

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1826954 - [devtools] Add http3 variant for devtools mochitest

Depends on D174528

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1826954 - Allow repeated nsHttpConnectionMgr timers in browser mochitests

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62802fc23ffe
[devtools] Disable devtools tests and test suites failing with http3 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/85ad3cfdbe1c
[devtools] Add http3 variant for devtools mochitest r=jmaher,kershaw
https://hg.mozilla.org/integration/autoland/rev/fc397a601a63
Allow repeated nsHttpConnectionMgr timers in browser mochitests r=Gijs

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for causing http3 failures e.g. browser_net_http3_request_details.js

• backout: https://hg.mozilla.org/integration/autoland/rev/9660566b4dc8dcb74a7f8e5bdb4cc52335991453
• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=fc397a601a63fb82e4bcbd9f82371ee0b42d3936&group_state=expanded
• failure log:
  • TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_http3_request_details.js | There should be 25 header values displayed in this tabpanel. - Got 26, expected 25
  • failure with no error, no log parsed
  • TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_original-source-link2.js | Failure: Link text changed to display correct location: doc_sourcemaps.scss:4 -

Comment 9

[Julian Descottes [:jdescottes]]

(In reply to Natalia Csoregi [:nataliaCs] from comment #8)

Backed out for causing http3 failures e.g. browser_net_http3_request_details.js

• backout: https://hg.mozilla.org/integration/autoland/rev/9660566b4dc8dcb74a7f8e5bdb4cc52335991453
• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=fc397a601a63fb82e4bcbd9f82371ee0b42d3936&group_state=expanded
• failure log:
  • TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_http3_request_details.js | There should be 25 header values displayed in this tabpanel. - Got 26, expected 25
  • failure with no error, no log parsed
  • TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_original-source-link2.js | Failure: Link text changed to display correct location: doc_sourcemaps.scss:4 -

Thanks for the ping.

• devtools/client/netmonitor/test/browser_net_http3_request_details.js : this is our only http3 test, it didn't fail at any point on try, but I will investigate
• failure with no error, no log parsed: what happened here is that a job was scheduled for a test suite (devtools/client/storage/test/browser.ini) which is skipped on this platform (http3). So there are no tests to run and the failure log is empty.
• devtools/client/inspector/rules/test/browser_rules_original-source-link2.js: the failure was on test-verify, which got triggered because I updated the test to https, and matches an old intermittent so I'm not really sure this is related. But I can disable the test for now.

Joel: Do you know how to handle cases where a job is scheduled on autoland with only skipped tests? It sounds like something that must have come up before?

Comment 10

[Julian Descottes [:jdescottes]]

I imagine this empty task issue is the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1772754?

Comment 11

[Julian Descottes [:jdescottes]]

(In reply to Julian Descottes [:jdescottes] from comment #9)

• devtools/client/netmonitor/test/browser_net_http3_request_details.js : this is our only http3 test, it didn't fail at any point on try, but I will investigate

So it seems that none of my try builds actually included the ini file for this test, which is odd because I just ran all the devtools browser chrome mochitests, so I thought it would include all test suites?

Comment 12

[Julian Descottes [:jdescottes]]

For browser_net_http3_request_details.js, it seems we intermittently get an additional TE header (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/TE), and therefore we can either get 25 or 26 headers listed. I will file a follow up bug to investigate why this header is not consistently returned, and in the meantime we should accept both 25 or 26.

For browser_rules_original-source-link2.js, I reverted the change for this file, and I'm now skipping this test as well as the similar browser_rules_original-source-link.js on http3.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

I suspect what is happening here is you need to add http3 to the task scheduling mozinfo:
https://searchfox.org/mozilla-central/source/taskcluster/gecko_taskgraph/util/chunking.py#43

you could give it a try with selecting some tasks and specific directories:
./mach try fuzzy -q 'test-linux devtools-chrome' devtools/client/storage/test/browser.ini

Comment 14

[Julian Descottes [:jdescottes]]

Attachment: Bug 1826954 - Add http3 to taskcluster chunking logic

Depends on D176401

Comment 15

[Julian Descottes [:jdescottes]]

(In reply to Joel Maher ( :jmaher ) (UTC -8) from comment #13)

I suspect what is happening here is you need to add http3 to the task scheduling mozinfo:
https://searchfox.org/mozilla-central/source/taskcluster/gecko_taskgraph/util/chunking.py#43

you could give it a try with selecting some tasks and specific directories:
./mach try fuzzy -q 'test-linux devtools-chrome' devtools/client/storage/test/browser.ini

Thanks for the suggestion! That seems to do the trick: https://treeherder.mozilla.org/jobs?repo=try&revision=f6157a9a3c8d63fc920a5ffbee1c0f78446f3d99 , no http3 job created there

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b846a5810c82
[devtools] Disable devtools tests and test suites failing with http3 r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/58dd3b6f76ad
[devtools] Add http3 variant for devtools mochitest r=jmaher,kershaw
https://hg.mozilla.org/integration/autoland/rev/1da79027b1e7
Allow repeated nsHttpConnectionMgr timers in browser mochitests r=Gijs
https://hg.mozilla.org/integration/autoland/rev/6ae3e7799d5d
Add http3 to taskcluster chunking logic r=jmaher

Comment 17

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b846a5810c82
https://hg.mozilla.org/mozilla-central/rev/58dd3b6f76ad
https://hg.mozilla.org/mozilla-central/rev/1da79027b1e7
https://hg.mozilla.org/mozilla-central/rev/6ae3e7799d5d