1827047 - Codepen demo (https://codepen.io/noeldelgado/pen/NPGmRO) is a lot slower with gpu-canvas compared to skia-canvas

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Go to https://codepen.io/noeldelgado/pen/NPGmRO

skia-canvas: https://share.firefox.dev/3KodYYE
gpu-canvas: https://share.firefox.dev/3UlNlIl

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Regression range:
2023-04-08T12:14:21.957000: DEBUG : Found commit message:
Bug 1826134 - Avoid interleaving glBufferSubData calls with draw calls in DrawTargetWebgl. r=gfx-reviewers,jgilbert,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D174685

Comment 3

[Jamie Nicol [:jnicol]]

Attachment: Bug 1827047 - Avoid unsynchronized BufferSubData fast-path on ANGLE. r?#gfx-reviewers

In bug 1826134 we added a fast-path to WebGLBuffer::BufferSubData used
by DrawTargetWebgl, which under the hood uses glMapBufferRange with
GL_MAP_UNSYNCHRONIZED_BIT. However, this causes performance issues on
ANGLE. This patch therefore avoids the fast-path on ANGLE, falling
back to a simple glBufferSubData instead.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826134

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41510d0f9dc5
Avoid unsynchronized BufferSubData fast-path on ANGLE. r=gfx-reviewers,lsalzman

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/41510d0f9dc5

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jnicol, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Jamie Nicol [:jnicol]]

Comment on attachment 9327939 [details]
Bug 1827047 - Avoid unsynchronized BufferSubData fast-path on ANGLE. r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Slow performance for windows users who have manually enabled accelerated canvas (off by default)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Reverts to previous behaviour. Not enabled by default
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Mayank Bansal]

Profile from latest Nightly: https://share.firefox.dev/3MCWJpt
This is fixed. Thanks!

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9327939 [details]
Bug 1827047 - Avoid unsynchronized BufferSubData fast-path on ANGLE. r?#gfx-reviewers

Approved for 113 beta 3, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/15c40e4b312a