1827050 - with webgl.out-of-process.async-present.force-sync= False and gpu-canvas enabled, codepen demo crashes if you reload the page

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Enable gpu-canvas
Set webgl.out-of-process.async-present.force-sync = False
Go to https://codepen.io/noeldelgado/pen/NPGmRO
Reload the page by Right Click on tab on tab-bar->"Reload Tab" (If the page doesnt crash, try force-reload)
AR: Screen flashes white
ER: Not so

https://crash-stats.mozilla.org/report/index/c76edca6-ed4c-4519-ac57-9577e0230408
https://crash-stats.mozilla.org/report/index/9c36d17d-9ad9-41e4-bc09-7d5a20230408

Comment 1

[Mayank Bansal]

Regression range:
Bug 1826134 - Avoid interleaving glBufferSubData calls with draw calls in DrawTargetWebgl. r=gfx-reviewers,jgilbert,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D174685

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:jnicol, since you are the author of the regressor, bug 1826134, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Mayank Bansal]

Attachment: about:support

Comment 4

[Lee Salzman [:lsalzman]]

Given the crash report, I think this was far more likely caused by something like bug 1826280, and not bug 1826134?

Comment 5

[Mayank Bansal]

Thats probable. The STR is only 90% reproducible. Sometimes, the page doesnt crash if you only do a simple reload, and may require a force-reload
Edit: I did another regression, and the same regression range from comment #1 came up.
Edit2: Deleted the regression builds cache, and did a third regression. The same range came up.

Comment 6

[Sotaro Ikeda [:sotaro]]

It seemed like a regression of bug 1826280.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1827050 - Check if TextureOwner exists before DUMMY_TEXTURE check

Comment 8

[Sotaro Ikeda [:sotaro]]

TextureOwner check needs to be done before DUMMY_TEXTURE check.

Crash happened because remoteTexture was nullptr in RemoteTextureMap::GetExternalImageIdOfRemoteTexture(). The remoteTexture was nullptr , since TextureOwner was already unregistered.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d587730da14
Check if TextureOwner exists before DUMMY_TEXTURE check r=lsalzman

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9d587730da14

Comment 11

[Mayank Bansal]

Cant repro this on the latest Nightly (built from https://hg.mozilla.org/mozilla-central/rev/25045b498bffc8cfaa17b0db903b3c53c11dc653)

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826280

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Sotaro Ikeda [:sotaro]]

Async RemoteTexture is not yet enabled by default.