1827222 - Check for shutdown while waiting for GPU process launch

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We have evidence that we try to resetup the GPU process during shutdown:
https://crash-stats.mozilla.org/report/index/fbfe5ff2-edaa-436b-9ebd-c3f020230409#tab-details

It appears that we do check for shutdown before launching the process:
https://searchfox.org/mozilla-central/rev/b9d6a9ab5cea31c8bcdf99541b02c1a2fca0daf8/gfx/ipc/GPUProcessManager.cpp#201

But between the process being launched and before we block the main thread on waiting for it to finish:
https://searchfox.org/mozilla-central/rev/b9d6a9ab5cea31c8bcdf99541b02c1a2fca0daf8/gfx/ipc/GPUProcessHost.cpp#86

Then we may have shutdown. We should probably check again in EnsureGPUReady before re-initializing everything.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

This is a bit complicated to fix because every instance of GPUProcessManager::EnsureGPUReady needs to now return multiple error codes. NS_OK for there is a GPU process, NS_ERROR_NOT_AVAILABLE for use the parent process, and NS_ERROR_ILLEGAL_DURING_SHUTDOWN for if it is called in the middle of shutdown. Or something equivalent.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1827222 - GPUProcessManager should not allow (re)initialization during shutdown.

We already avoid launching the GPU process during shutdown, but shutdown
could happen after we initiated the launch and before it completes. Top
level IPDL protocols assert that we don't create them during shutdown,
so we need to be more diligent about checking for that.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:aosmond, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Waiting for green try: https://treeherder.mozilla.org/jobs?repo=try&revision=09bbfa35172e890f29aa2135ba284adb62b8cf49

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Try keeps failing. It is probably fine.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/028514f49809
GPUProcessManager should not allow (re)initialization during shutdown. r=jnicol

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/028514f49809