1827327 - Fix dom/serviceworkers/test/test_third_party_iframes.html test on Android Fission

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[[:owlish] 🦉 PST]

mochitest-plain variant. Debug builds.

e.g. https://treeherder.mozilla.org/push-health/push?repo=try&revision=da4dc488078970e3e60ef6964e275f46ba9c456e&testGroup=pr

Comment 1

[Nika Layzell [:nika] (ni? for response)]

This appears to be an assertion failure during AllocPWebRenderBridgeParent (https://treeherder.mozilla.org/logviewer?job_id=409186631&repo=try&lineNumber=2906). Specifically this line appears to be failing: https://searchfox.org/mozilla-central/rev/11dbac7f64f509b78037465cbb4427ed71f8b565/gfx/layers/ipc/ContentCompositorBridgeParent.cpp#158

Redirecting to Core :: Graphics: WebRender to get eyes more familiar with what this assertion could mean on it.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gw, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Glenn Watson [:gw]]

Sotaro, what would be an appropriate severity for this bug?

Comment 4

[Chris Peterson [:cpeterson]]

Sotaro, this test failure blocks Android Fission, so the Firefox Android team is eager for this test to be fixed. If you have questions about running Android tests in Fission mode, reach out to :owlish in the #fission channel on Slack or Matrix.

Comment 5

[Sotaro Ikeda [:sotaro]]

:cpeterson, do you know how to enable fission test on Android? Just removing the following from dom/serviceworkers/test/mochitest-common.ini seemed not enough.

skip-if = fission && os == "android" # Bug 1827327"

https://treeherder.mozilla.org/jobs?repo=try&revision=bb2a03726a874fab064faaa72224f49ec3326d9c
https://hg.mozilla.org/try/rev/2871e14fdcbefa288a053200e9b4206f0648e523

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Sotaro Ikeda [:sotaro] from comment #5)

:cpeterson, do you know how to enable fission test on Android? Just removing the following from dom/serviceworkers/test/mochitest-common.ini seemed not enough.

Irene, can you please share the instructions for enabling Fission for Android tests? Are the instructions the same for local builds and Try pushes?

Comment 7

[[:owlish] 🦉 PST]

Removing that line should be enough. Maybe also disable or investigate the test that failed in that try push? AFAIK the rest of the chunk is not getting run after one failure.

To run locally on Fission, simply run the test with no command options. To run without Fission, use --disable-fission command option

Comment 8

[Sotaro Ikeda [:sotaro]]

I confirmed the test failure by removing other tests of mochitest-common.ini.
https://treeherder.mozilla.org/jobs?repo=try&author=sikeda.birchill%40mozilla.com&selectedTaskRun=eZGvtzoLQPCXvkyzu1I59A.0
https://hg.mozilla.org/try/rev/1333c150cff244e2bba1d480fba2a73616b5ac8c

Comment 9

[Sotaro Ikeda [:sotaro]]

By adding logs, the problem seemed to be triggered by unexpected gpu process shutdown.

https://treeherder.mozilla.org/jobs?repo=try&revision=d8985df630db1d9f3b0963b03a1529f11d07ab9f

GPUProcessManager::HandleProcessLost() triggered GPU process launch.

Since the GPU process launched, the followings were called.
GPUProcessManager::OnProcessLaunchComplete()
-->GPUProcessManager::ReinitializeRendering()
-->ContentParent::OnCompositorUnexpectedShutdown()
-->ContentChild::RecvReinitRendering()
-->BrowserChild::ReinitRendering()
-->PBrowserChild::SendEnsureLayersConnected()
-->BrowserParent::RecvEnsureLayersConnected()
-->RemoteLayerTreeOwner::EnsureLayersConnected()

RemoteLayerTreeOwner::EnsureLayersConnected() was failed in the following.

• https://searchfox.org/mozilla-central/rev/da1e39f50ef43145623938141c970437b226da9e/layout/ipc/RemoteLayerTreeOwner.cpp#90

Then LayersId was not registered. It cased the assert failure.

Comment 10

[Sotaro Ikeda [:sotaro]]

GPU process shutdown seemed to be triggered by Bug 1827330. Then it seems better to wait Bug 1827330 fix for now. We could re-rest after the fix.

Comment 11

[Chris Peterson [:cpeterson]]

(In reply to Sotaro Ikeda [:sotaro] from comment #10)

GPU process shutdown seemed to be triggered by Bug 1827330. Then it seems better to wait Bug 1827330 fix for now. We could re-rest after the fix.

Good news! The fix for bug 1827330 just merged to mozilla-central a few hours ago. :)

Comment 12

[Sotaro Ikeda [:sotaro]]

The test seemed to be addressed by Bug 1827330 fix.

https://treeherder.mozilla.org/jobs?repo=try&revision=3034ba6c732663e102f98368d6f9ac7f70e66457

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Sotaro, we should remove this skip-if annotation in this bug, right?

Comment 14

[Sotaro Ikeda [:sotaro]]

Oh, I forgot to do it. Thank you.

Comment 15

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1827327 - Remove skip-if of test_third_party_iframes.html

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93ed44df5382
Remove skip-if of test_third_party_iframes.html r=hiro

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/93ed44df5382