1827396 - [wpt-sync] Sync PR 39472 - Strip comment tokens when parsing pending substitutions.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39472 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39472
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

Strip comment tokens when parsing pending substitutions.

CSSPropertyParser::ParseValue() isn't ready for comment tokens,
which we now preserve since we need them for the original text.
Strip them out right before parsing; as the comment says,
this probably isn't optimal, but it shouldn't be too bad either.

Fixed: 1430953
Fixed: 1431444
Change-Id: I3f1039ddd4424b1d0a72e42cc2ba4fa1a243ca0c

Reviewed-on: https://chromium-review.googlesource.com/4414717
WPT-Export-Revision: f54fd50e3aeb162e5a673ec92c5ce934000fa014

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5881003acf488c6164254d215ea658df43fbd4e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PASS: 3

Chrome

OK : 1
PASS: 2
FAIL: 1

Safari

OK : 1
PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b060f00f0bb
[wpt PR 39472] - Strip comment tokens when parsing pending substitutions., a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1b060f00f0bb