1827431 - When migrating from a browser that uses multiple profiles, all resources are imported no matter what is selected from the wizard

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

I noticed this while doing some exploratory testing of the new migration wizard. This line here:

https://searchfox.org/mozilla-central/rev/2ce39261ea6a69e49d87f76a119494b2a7a7e42a/browser/components/migration/MigrationWizardParent.sys.mjs#162

isn't passing the profileObj into getMigrateData, so getMigrateData is always returning 0, which maps to MigrationUtils.resourceTypes.ALL.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Make sure Chrome is installed, and make sure there are some bookmarks and history in the Chrome profile to migrate.
2. Open the new migration wizard, and choose the Chrome profile set up in (1) to migrate
3. Make sure "Bookmarks" is unchecked, and "History" is checked, and click "Import"

ER:

Only History should be imported.

AR:

All resources are imported.

[Tracking Requested - why for this release]:

Tracking for 113 because, despite this not being enabled by default in 113 on Beta or Release, we do plan on running a small experiment on 113 to test the new migration wizard, and we should make sure this fix is in.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1827431 - Make sure to select the appropriate profile when choosing what resource data is available for migration. r?Gijs!

We weren't passing the appropriate profile object to getMigrateData, and thanks to mocking,
we didn't catch this in automated testing.

This patch fixes the issue, and updates our mocking helpers to ensure that the expected
profile object gets passed to the getResources calls during mochitest-browser tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b84e3007c940
Make sure to select the appropriate profile when choosing what resource data is available for migration. r=niklas

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b84e3007c940

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9327955 [details]
Bug 1827431 - Make sure to select the appropriate profile when choosing what resource data is available for migration. r?Gijs!

Beta/Release Uplift Approval Request

• User impact if declined: Users in a treatment branch to test the new migration wizard in Firefox 113 might find that it imports more than expected.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 1.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small, well-contained, well-understood patch in a newer and well-understood part of the codebase that includes a comprehensive suite of automated tests.
• String changes made/needed: None.
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9327955 [details]
Bug 1827431 - Make sure to select the appropriate profile when choosing what resource data is available for migration. r?Gijs!

Approved for 113.0b4.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c930972d98f

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 114.0a1 (2023-04-11) on Windows 10x64. Choosing to import only History from Google Chrome will also import passwords and bookmarks.
The issue is verified fixed with Firefox 114.0a1 (2023-04-18) and Firefox 113.0b5 on Windows 10x64, macOS 12 and Ubuntu 20.04. Only the selected option is imported from another browser.