1827564 - [wpt-sync] Sync PR 39488 - Handle min/max sizes in non-replaced positioned boxes

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39488 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39488
Details from upstream follow.

Delan Azabani <[e-mail]> wrote:

Handle min/max sizes in non-replaced positioned boxes

This patch makes HoistedAbsolutelyPositionedBox handle min/max sizes in the non-replaced case, per CSS2 #min-max-widths and #min-max-heights. No changes are made to the replaced case.

3 new tests:

• /css/CSS2/positioning/absolute-non-replaced-max-001.html (fails under layout 2013)
• /css/CSS2/positioning/absolute-non-replaced-min-001.html (fails under layout 2013)
• /css/CSS2/positioning/absolute-non-replaced-min-max-001.html (passes under layout 2013)

13 tests now pass:

• /css/CSS2/positioning/absolute-non-replaced-max-height-002.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-003.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-007.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-008.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-009.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-011.xht
• /css/CSS2/positioning/absolute-non-replaced-width-025.xht
• /css/CSS2/positioning/absolute-non-replaced-width-026.xht
• /css/CSS2/positioning/abspos-change-in-inline-block.html
• /css/CSS2/positioning/abspos-width-change-inline-container-001.html
• /css/CSS2/positioning/detach-abspos-before-layout.html
• /css/CSS2/positioning/relpos-percentage-left-in-scrollable-2.html
• /css/CSS2/positioning/relpos-percentage-left-in-scrollable.html

11 tests would now pass if <br> was inserted between the two <img> tags in the reference (#29591):

• /css/CSS2/positioning/absolute-non-replaced-height-003.xht
• /css/CSS2/positioning/absolute-non-replaced-height-004.xht
• /css/CSS2/positioning/absolute-non-replaced-height-005.xht
• /css/CSS2/positioning/absolute-non-replaced-height-010.xht
• /css/CSS2/positioning/absolute-non-replaced-height-011.xht
• /css/CSS2/positioning/absolute-non-replaced-height-012.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-004.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-005.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-006.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-010.xht
• /css/CSS2/positioning/absolute-non-replaced-max-height-012.xht

1 test continues to fail, but the expectation was out of date:

• /css/CSS2/positioning/relpos-percentage-top-in-scrollable.html

Reviewed in servo/servo#29594

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=48f275d6d22e9e0edcdc36323e3876bb22f626d7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

PASS: 3

Safari

PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50e4407471d3
[wpt PR 39488] - Handle min/max sizes in non-replaced positioned boxes, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/50e4407471d3