1827726 - WebSocketConnection _log shows up in performance profiles even if trace logs are disabled

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Julian Descottes [:jdescottes]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1787436#c14

Not the worst offender, but the log method is relatively complex, and when a lot of events are emitted (eg network) it starts showing up in profiles:

  _log(direction, data) {
    function replacer(key, value) {
      if (typeof value === "string") {
        return lazy.truncate`${value}`;
      }
      return value;
    }

    const payload = JSON.stringify(
      data,
      replacer,
      lazy.Log.verbose ? "\t" : null
    );

    lazy.logger.trace(
      `${this.constructor.name} ${this.id} ${direction} ${payload}`
    );
  }

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1827726 - [remote] Skip WebSocketConnection _log if debug logs are disabled

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/904e32a37284
[remote] Skip WebSocketConnection _log if debug logs are disabled r=webdriver-reviewers,whimboo

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/904e32a37284