1827727 - ../skia/src/opts/SkRasterPipeline_opts.h:236:81: error: no match for 'operator*' (operand types are 'float32x4_t' and 'skvx::Vec<4, float>')

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[tt_1]

Attachment: firefox-nightly-skia-broken.log.gz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

I downloaded latest git sources and compiled them for armv7a

Actual results:

skia is broken with:

18:05.75 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:236:81: error: no match for 'operator*' (operand types are 'float32x4_t' and 'skvx::Vec<4, float>')
18:05.82 /usr/lib/gcc/armv7a-unknown-linux-gnueabihf/10.4.0/include/g++-v10/type_traits:2554:11: error: no type named 'type' in 'struct std::enable_if<false, void>'
18:05.85 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:242:64: error: no matching function for call to 'skvx::Vec<4, unsigned int>::Vec(neon::I32&)'
18:05.97 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:272:21: error: no match for 'operator*' (operand types are 'neon::F' {aka 'skvx::Vec<4, float>'} and '__simd128_float32_t')
18:06.02 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:1044:62: error: no matching function for call to 'skvx::Vec<4, int>::Vec(neon::U32&)'
18:06.13 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:116:77: error: no matching function for call to 'skvx::Vec<4, unsigned int>::Vec(skvx::Vec<4, int>)'
18:06.24 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:1124:24: error: no matching function for call to 'skvx::Vec<4, int>::Vec(neon::U32&)'
18:06.36 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:1145:24: error: no matching function for call to 'skvx::Vec<4, int>::Vec(neon::U32&)'
18:06.67 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:5531:40: error: no matching function for call to 'skvx::Vec<8, short int>::Vec(skvx::Vec<8, short unsigned int>)'
18:06.99 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:116:73: error: no matching function for call to 'cast<skvx::Vec<8, short unsigned int>::elem_type>(__simd64_uint8_t&)'

Expected results:

I expect the compile to pass smothly and bake me a nice firefox nightly, seems skia has other plans for me. Will double check, if the non-neon build is broken as well. The compressed build log is attached.

The skia update has been backed out, I was unable to understand if the people in bug 1821512 already know of this breakage.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:lsalzman, since you are the author of the regressor, bug 1821512, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[tt_1]

slightly different error on aarch64:

18:35.16 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:236:81: error: no match for 'operator*' (operand types are 'float32x4_t' and 'skvx::Vec<4, float>')
18:35.19 /usr/lib/gcc/aarch64-unknown-linux-gnu/10.4.0/include/g++-v10/type_traits:2554:11: error: no type named 'type' in 'struct std::enable_if<false, void>'
18:35.19 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:242:64: error: no matching function for call to 'skvx::Vec<4, unsigned int>::Vec(neon::I32&)'
18:35.25 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:245:53: error: no matching function for call to 'skvx::Vec<4, unsigned int>::Vec(neon::I32&)'
18:35.30 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:246:53: error: no matching function for call to 'skvx::Vec<4, unsigned int>::Vec(neon::I32&)'
18:35.35 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:1044:62: error: no matching function for call to 'skvx::Vec<4, int>::Vec(neon::U32&)'
18:35.40 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:116:77: error: no matching function for call to 'skvx::Vec<4, unsigned int>::Vec(skvx::Vec<4, int>)'
18:35.42 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:1112:25: error: cannot convert 'neon::U16' {aka 'skvx::Vec<4, short unsigned int>'} to 'float16x4_t'
18:35.42 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:1133:24: error: could not convert 'vcvt_f16_f32(f.skvx::Vec<4, float>::operator skvx::ConvertNative<4, float>::type())' from 'float16x4_t' to 'neon::U16' {aka 'skvx::Vec<4, short unsigned int>'}
18:35.86 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:5531:40: error: no matching function for call to 'skvx::Vec<8, short int>::Vec(skvx::Vec<8, short unsigned int>)'
18:36.20 /var/tmp/portage/www-client/firefox-114.0/work/firefox-114.0/gfx/skia/skia/src/opts/SkRasterPipeline_opts.h:116:73: error: no matching function for call to 'cast<skvx::Vec<8, short unsigned int>::elem_type>(__Uint8x8_t&)'

Comment 4

[tt_1]

It did pass with gcc-10 on amd64, will try again now that it relanded.

Comment 5

[Lee Salzman [:lsalzman]]

Attachment: Bug 1827727 - Fix building Skia on GCC ARM. r?aosmond

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1821512

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93321213539f
Fix building Skia on GCC ARM. r=aosmond,gfx-reviewers

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/93321213539f