1827862 - Set network.cookie.blockUnicode=true

Status: NEW

(Core :: Networking: Cookies, task, P3)

Comment 1

[Valentin Gosu [:valentin]]

Attachment: Bug 1827862 - Set network.cookie.blockUnicode=true r=edgul!,dveditz!

Comment 2

[Daniel Veditz [:dveditz]]

This makes Firefox enforce the syntax in the spec and appears to match what chromium source code is doing. folks have talked about doing (but does not yet).

Comment 3

[Daniel Veditz [:dveditz]]

We need to make sure this change gets added to the release notes to give people a chance to understand why they might be broken.

Comment 4

[Valentin Gosu [:valentin]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This change makes Firefox reject cookies that contain non-ascii characters.
[Affects Firefox for Android]: Yes
[Suggested wording]:

Cookies with non-ascii characters in the name or value will be rejected. Example:

>> document.cookie="🙂=face"
⚠️ Cookie “🙂” has been rejected for invalid characters in the name.

>> document.cookie="smiley=🙂"
⚠️ Cookie “smiley” has been rejected for invalid characters in the value.

[Links (documentation, blog post, etc)]:

Comment 5

[Valentin Gosu [:valentin]]

https://treeherder.mozilla.org/jobs?repo=try&revision=512f631b6f9e1aed67445df364e1f96e29d9848c

This is breaking some tests:
WPT /cookies/encoding/charset.html
dom/html/test/test_non-ascii-cookie.html
dom/manifest/test/browser_ManifestObtainer_credentials.js

Comment 6

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:valentin, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 7

[Valentin Gosu [:valentin]]

This is not ready yet. We are coordinating with Chrome, but this may have a bigger impact and chance of regressions in some countries than others.