1827892 - [wpt-sync] Sync PR 39522 - [scroll-animations] Implement deferred timeline attachment

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39522 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39522
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[scroll-animations] Implement deferred timeline attachment

This CL implements the behavior behind the *-timeline-attachment
properties.

During CSSAnimations::CalculateTimelineUpdate, we now also calculate
the "attaching timelines", which means the deferred timelines in the
ancestor chain which correspond to the current element's timelines
with attachment=ancestor.

As usual, the pending changes to the "attaching timelines" are stored
on CSSAnimationUpdate, and only applied when (or if) CSSAnimations::
MaybeApplyPendingUpdate is called.

A couple of things are deferred to later CLs:

• The behavior of ancestor-attached timelines with nothing to
  attach to. This is not clear yet.
• Ensuring a sufficiently severe style recalc of children
  when the computed value of *-timeline-attachment property changes.

Bug: 1425939
Change-Id: I69ebc95c3936cb7276721d35b690e582188d9a9f

Reviewed-on: https://chromium-review.googlesource.com/4422650
WPT-Export-Revision: 4f027c149d5646806fb7505877981ad9b13d755b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=56381b124f8d611937251dc3bd027f01b3b0fa5f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 10 subtests

Status Summary

Firefox

OK : 2
PASS: 4
FAIL: 15

Chrome

OK : 2
PASS: 3
FAIL: 16

Safari

OK : 2
PASS: 4
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /scroll-animations/css/scroll-timeline-attachment.html [wpt.fyi]
  • Descendant can attach to deferred timeline: FAIL (Chrome: FAIL, Safari: FAIL)
  • Timeline with ancestor attachment does not attach to local: FAIL (Chrome: PASS, Safari: FAIL)
  • Axis of deferred timeline is taken from attached timeline: FAIL (Chrome: FAIL, Safari: FAIL)
  • Axis of deferred timeline with multiple attachments: FAIL (Chrome: FAIL, Safari: FAIL)
  • Dynamically re-attaching: FAIL (Chrome: FAIL, Safari: FAIL)
  • Dynamically attaching: FAIL (Chrome: FAIL, Safari: FAIL)
  • Dynamically detaching: FAIL (Chrome: FAIL, Safari: FAIL)
• /scroll-animations/css/view-timeline-attachment.html [wpt.fyi]
  • Descendant can attach to deferred timeline: FAIL (Chrome: FAIL, Safari: FAIL)
  • Axis of deferred timeline is taken from attached timeline: FAIL (Chrome: FAIL, Safari: FAIL)
  • Axis of deferred timeline with multiple attachments: FAIL (Chrome: FAIL, Safari: FAIL)
  • Inset of deferred timeline is taken from attached timeline: FAIL (Chrome: FAIL, Safari: FAIL)
  • Dynamically re-attaching: FAIL (Chrome: FAIL, Safari: FAIL)
  • Dynamically attaching: FAIL (Chrome: FAIL, Safari: FAIL)
  • Dynamically detaching: FAIL (Chrome: FAIL, Safari: FAIL)
  • Mixing deferred scroll and view-timelines: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06f10f20e398
[wpt PR 39522] - [scroll-animations] Implement deferred timeline attachment, a=testonly
https://hg.mozilla.org/integration/autoland/rev/45fa7376a5e0
[wpt PR 39522] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/06f10f20e398
https://hg.mozilla.org/mozilla-central/rev/45fa7376a5e0