1827903 - Browser list is cut off inside Import Browser data when having multiple browsers or profiles or reduced height

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P1)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: image.png

Found in

• 114.0a1 (2023-04-13)

Affected versions

• 114.0a1 (2023-04-13)
• 113.0b3 (default disabled)

Tested platforms

• Affected platforms: Windows 10x64, Ubuntu 20.04, macOS 12
• Unaffected platforms: none

Preconditions

• browser.migrate.content-modal.enabled:true
• have multiple browsers or multiple accounts for one browser that contains bookmarks

Steps to reproduce

1. Open about:preferences and click on Import data.
2. Click the dropdown menu to choose a browser and observe the window.

Expected result

• All browsers are correctly displayed, or maybe a scroll bar is present.

Actual result

• The browsers do not fit inside the dropdown and sometimes the dropdown is cut off.

Regression range

• Most likely started with the implementation of the new Import Wizard Experience. Will search for one ASAP to be sure.

Additional notes

• Attached a screenshot.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I think this can be fixed by setting style.overflow = "scroll" here: https://searchfox.org/mozilla-central/rev/ad732108b073742d7324f998c085f459674a6846/browser/components/migration/content/migration-wizard.mjs#310

Can you try this, Portia?

Comment 2

[portiawuu]

Attachment: Bug 1827903 - Browser list is cut off inside Import Browser data when having multiple browsers or profiles or reduced height.r=mconley!,kpatenio!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

ni'ing mstriemer for https://phabricator.services.mozilla.com/D175447#5782471.

Comment 4

[ddl-github]

Same or similar bug? A friend posted today: "first time setup of a new FF instance with no existing ff/moz profile, and I was trying to pick a chrome profile to import", presented with window with no accessible controls, which does not scroll or resize. See screenshot in his mastodon post.

Comment 5

[Asif Youssuff]

(In reply to ddl-github from comment #4)

Same or similar bug? A friend posted today: "first time setup of a new FF instance with no existing ff/moz profile, and I was trying to pick a chrome profile to import", presented with window with no accessible controls, which does not scroll or resize. See screenshot in his mastodon post.

FWIW, this seems like a different bug, as the bug here is using the new migration UI (you can see a screenshot at https://blog.nightly.mozilla.org/2023/04/14/jam-packed-with-updates-these-weeks-in-firefox-issue-135/).

Comment 6

[ddl-github]

(In reply to Asif Youssuff from comment #5)

(In reply to ddl-github from comment #4)

Same or similar bug? A friend posted today: "first time setup of a new FF instance with no existing ff/moz profile, and I was trying to pick a chrome profile to import", presented with window with no accessible controls, which does not scroll or resize. See screenshot in his mastodon post.

FWIW, this seems like a different bug, as the bug here is using the new migration UI (you can see a screenshot at https://blog.nightly.mozilla.org/2023/04/14/jam-packed-with-updates-these-weeks-in-firefox-issue-135/).

Thanks. I can't directly reproduce it myself without a bit of a hassle (i.e. install Chrome and create a bunch of profiles, preferably on a Mac). Is it reasonable to create a new bug report with second-hand info like this?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24c4e22b5d00
Browser list is cut off inside Import Browser data when having multiple browsers or profiles or reduced height.r=mconley

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/24c4e22b5d00

Comment 9

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 114.0a1 (2023-04-26) on Windows 10x64, macOS 12 and Ubuntu 20.04. A scrollbar is displayed and the items can be successfully scrolled when multiple browsers or profiles are available to import from.