1827905 - Simplify manifestPlaceholders in build variants

Status: VERIFIED FIXED

(Firefox for Android :: General, task, P1)

Description

[Jonathan Almeida [:jonalmeida]]

We have attributes in the manifestPlaceholders that need to be changed depending on the build variant.

In our current configuration, we re-set the default values in every variant rather than setting on the changes - this is error prone.

We should make this better because we have added more manifestPlaceholders and we will probably add more in the future, so we should limit the chance of making mistakes.

Fenix defaults: https://searchfox.org/mozilla-mobile/rev/a494670a2dc9b9ecd8341e07886b5af1a2f0209a/firefox-android/fenix/app/build.gradle#80-84
Focus defaults: Do not exist. Should be added here.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1827905 - Update manifestPlaceholders in variants instead of reinit (#1967)

Comment 2

[BMO Github Automation]

Authored by https://github.com/jonalmeida
https://github.com/mozilla-mobile/firefox-android/commit/f64caf62757cfd137bc48bba9fd133676792997e
[main] Bug 1827905 - Update manifestPlaceholders in variants instead of reinit

Comment 3

[Adina Petridean QA [:apetridean]]

Hello Jonathan,

Is QA verification needed for this issue? If so, could you please provide us with some steps to reproduce (STR) or testing scenarios?

Thank you!

Comment 4

[Jonathan Almeida [:jonalmeida]]

Hi Adina, sorry, I forgot to add some STR!

This change should ensure that we haven't caused any regressions to our deep links.

STR:

1. From the command line with your device connected, run the follow commands:
2. adb shell am start -W -a android.intent.action.VIEW -d "fenix-nightly://settings"
3. adb shell am start -W -a android.intent.action.VIEW -d "fenix-dev://settings"
4. adb shell am start -W -a android.intent.action.VIEW -d "fenix-beta://settings"
5. adb shell am start -W -a android.intent.action.VIEW -d "fenix://settings"

Expected results:

• At step 2, we should open Fenix Nightly to the Settings page.
• At step 3, we should NOT open Fenix Nightly to the Settings page (if you have another builds installed, those might be opened).
• At step 4, we should NOT open Fenix Nightly to the Settings page (if you have another builds installed, those might be opened).
• At step 5, we should NOT open Fenix Nightly to the Settings page (if you have another builds installed, those might be opened).

Comment 5

[Adina Petridean QA [:apetridean]]

Thank you Jonathan!

Verified as fixed on the latest Nightly version 115.0a1 - 11.05.2023 using Motorola Moto G9 plus (Android 11) device and following the aforementioned steps.