Open Bug 1827933 Opened 3 years ago Updated 3 years ago

ServerError shown instead of KeyboardInterrupt (or nothing)

Categories

(Conduit :: moz-phab, defect, P3)

Tracking

(Not tracked)

REOPENED

People

(Reporter: zeid, Unassigned)

Details

(Keywords: conduit-triaged, good-first-bug)

STR:

  • Submit a patch using moz-phab
  • At the yes/no prompt, press Ctrl-C to abort

Actual behaviour:

Submit to https://phabricator-dev.allizom.org (YES/No/Always)? ^C
Cancelled
ServerError: server exited with status 255: b'interrupted!'
Run moz-phab again with '--trace' to show debugging output

Expected behaviour:

Submit to https://phabricator-dev.allizom.org (YES/No/Always)? ^C
Cancelled
Summary: ServerError shown instead of KeyboardInterrupt → ServerError shown instead of KeyboardInterrupt (or nothing)

Can you run with --trace?

Flags: needinfo?(zeid)

Hmm odd -- I'm not able to reproduce any more, if it happens again I'll do a trace.

Flags: needinfo?(zeid)

Closing bug; reopen with a trace if it happens again.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME

By accident I reproduced this in suite.

DEBUG    2023-04-19 17:26:53,729 $ hg bookmark -T '{bookmark}\n' --pager never
ERROR    2023-04-19 17:26:53,774 Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/mozphab/mozphab.py", line 123, in main
    args.func(repo, args)
  File "/usr/local/lib/python3.10/site-packages/mozphab/commands/submit.py", line 707, in submit
    _submit(repo, args)
  File "/usr/local/lib/python3.10/site-packages/mozphab/commands/submit.py", line 563, in _submit
    res = prompt(
  File "/usr/local/lib/python3.10/site-packages/mozphab/helpers.py", line 267, in prompt
    res = input(prompt_str)
  File "/usr/local/lib/python3.10/site-packages/mozphab/spinner.py", line 22, in signal_sigint
    raise KeyboardInterrupt()
KeyboardInterrupt

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/mozphab/mozphab.py", line 125, in main
    repo.cleanup()
  File "/usr/local/lib/python3.10/site-packages/mozphab/mercurial.py", line 261, in cleanup
    bookmarks = self.hg_out(["bookmark", "-T", "{bookmark}\n"])
  File "/usr/local/lib/python3.10/site-packages/mozphab/mercurial.py", line 199, in hg_out
    out = self.repository.rawcommand(command, eh=error_handler)
  File "/usr/local/lib/python3.10/site-packages/hglib/client.py", line 258, in rawcommand
    ret = self.runcommand(args, inchannels, outchannels)
  File "/usr/local/lib/python3.10/site-packages/hglib/client.py", line 192, in runcommand
    channel, data = self._readchannel()
  File "/usr/local/lib/python3.10/site-packages/hglib/client.py", line 152, in _readchannel
    raise error.ServerError('server exited with status %d: %s'
hglib.error.ServerError: server exited with status 255: b'interrupted!'

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
You need to log in before you can comment on or make changes to this bug.