Implement the weather suggestion result menu UI
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
See revision summary
|
Assignee | |
Comment 1•1 year ago
|
||
This implements the weather suggestion result menu UI and builds on D174941.
References:
- Spec (See "A11y review" in the sidebar)
- Clickable prototype (See "Revised 4/3" in the sidebar)
There are a couple important points about the menu. First, one of the commands,
"Report inaccurate location", is specific to weather suggestions, or at least
location-based suggestions. I don't think it's a good idea to centralize all
commands in UrlbarView, and in general I'd like to stop centralizing handling of
different result types in the view and input, so I added a new provider method
called getResultCommands().
Second, the spec calls for a menu separator and a submenu so the user can select
a reason they don't want to see the result, so the return value of
getResultCommands() is flexible enough to support those two things, and I
modified #populateResultMenu() too.
These new commands will be recorded in Glean engagement telemetry as new
engagement_type values, same as "dismiss" and "help" currently are.
This patch doesn't implement handling of two of the commands, "Report inaccurate
location" and "Show less frequently", because I wanted to keep it focused on the
fundamentals described above.
Depends on D174941
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/04c3a110f644 Implement the weather suggestion result menu UI. r=dao,fluent-reviewers,flod
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Description
•