1827969 - Remove about:welcome Colorways code

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1820477 +++

All of this code should be good to go since there's no active colorway collection anymore: https://searchfox.org/mozilla-central/search?q=colorway&path=newtab&case=false&regexp=false

Comment 1

[:Gijs (he/him)]

Dão, is this something you're interested in picking up? If not (and/or you're busy atm), fancy making it a mentored bug?

Comment 2

[Dão Gottwald [:dao]]

Got Amy to agree to look into this. :)

Comment 3

[Amy Churchwell [:amy]]

Attachment: Bug 1827969 - Remove about:welcome Colorways code. r=#omc-reviewers

Comment 4

[Dão Gottwald [:dao]]

So unfortunately this patch seems to have stalled for perhaps still missing some colorway stuff. Can we get it rebased and landed regardless (assuming tests are happy), and file a followup on removing the rest?

Comment 5

[Amy Churchwell [:amy]]

Attachment: Bug 1827969 - Remove about:welcome Colorways code. r=#omc-reviewers

Differential Reversion: https://phabricator.services.mozilla.com/D180887

Comment 7

[Amy Churchwell [:amy]]

Thanks for flagging this Dão, patch has been rebased/updated/approved -- requesting to land today.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51a922bf4c7e
Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn

Comment 9

[Iulian Moraru]

Backed out for causing bc failures on browser_all_files_referenced.js.

• Push with failures

• Failure log

• Backout link

<...>
[task 2023-11-14T19:35:26.172Z] 19:35:26     INFO - indirectly allowlisted file: chrome://fxr/content/assets/icon-logo-settings-preview.png used from chrome://fxr/content/prefs.html
[task 2023-11-14T19:35:26.172Z] 19:35:26     INFO - indirectly allowlisted file: chrome://fxr/content/assets/icon-reportissue.svg used from chrome://fxr/content/prefs.html
[task 2023-11-14T19:35:26.173Z] 19:35:26     INFO - indirectly allowlisted file: chrome://fxr/content/prefs.js used from chrome://fxr/content/prefs.html
[task 2023-11-14T19:35:26.174Z] 19:35:26     INFO - Buffered messages finished
[task 2023-11-14T19:35:26.176Z] 19:35:26     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected +0
[task 2023-11-14T19:35:26.176Z] 19:35:26     INFO - Stack trace:
[task 2023-11-14T19:35:26.176Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:test_is:1611
[task 2023-11-14T19:35:26.177Z] 19:35:26     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1027
[task 2023-11-14T19:35:26.177Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:handleTask:1134
[task 2023-11-14T19:35:26.178Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
[task 2023-11-14T19:35:26.178Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1348
[task 2023-11-14T19:35:26.178Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1123
[task 2023-11-14T19:35:26.178Z] 19:35:26     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2023-11-14T19:35:26.179Z] 19:35:26     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-11-14T19:35:26.180Z] 19:35:26     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://activity-stream/content/data/content/assets/default.svg - 
[task 2023-11-14T19:35:26.180Z] 19:35:26     INFO - Stack trace:
[task 2023-11-14T19:35:26.180Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:test_ok:1583
[task 2023-11-14T19:35:26.180Z] 19:35:26     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:1031
[task 2023-11-14T19:35:26.180Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:handleTask:1134
[task 2023-11-14T19:35:26.181Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
[task 2023-11-14T19:35:26.181Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1348
[task 2023-11-14T19:35:26.181Z] 19:35:26     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1123
[task 2023-11-14T19:35:26.181Z] 19:35:26     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2023-11-14T19:35:26.181Z] 19:35:26     INFO - ignored unused allowlist entry: resource://app/blocklist.xml
[task 2023-11-14T19:35:26.182Z] 19:35:26     INFO - ignored unused allowlist entry: resource://gre/gmp-clearkey/0.1/manifest.json
[task 2023-11-14T19:35:26.182Z] 19:35:26     INFO - ignored unused allowlist entry: resource://gre/res/test.properties
[task 2023-11-14T19:35:26.183Z] 19:35:26     INFO - missing file: resource://gre/modules/WebNavigation.jsm
[task 2023-11-14T19:35:26.184Z] 19:35:26     INFO - missing file: resource://test/ReturnCodeChild.sys.mjs
[task 2023-11-14T19:35:26.184Z] 19:35:26     INFO - missing file: resource://gre/modules/ExtensionProcessScript.jsm
[task 2023-11-14T19:35:26.185Z] 19:35:26     INFO - missing file: resource://test/ReturnCodeChild.jsm
[task 2023-11-14T19:35:26.185Z] 19:35:26     INFO - missing file: chrome://aboutsync/content/AboutSyncRedirector.js
[task 2023-11-14T19:35:26.186Z] 19:35:26     INFO - Console message: No chrome package registered for chrome://aboutsync/content/AboutSyncRedirector.js
[task 2023-11-14T19:35:26.186Z] 19:35:26     INFO - missing file: resource://search-extensions/yandex/__MSG_extensionIcon__
[task 2023-11-14T19:35:26.187Z] 19:35:26     INFO - missing file: resource://gre-resources/accessiblecaret-normal.svg referenced from resource://content-accessible/accessiblecaret.css
[task 2023-11-14T19:35:26.188Z] 19:35:26     INFO - missing file: resource://gre-resources/accessiblecaret-tilt-left.svg referenced from resource://content-accessible/accessiblecaret.css
<...>

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4424163a8bf
Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn

Comment 11

[Cristian Tuns]

Backed out for causing bc failures in browser_all_files_referenced.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://activity-stream/content/data/content/assets/default.svg -

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6176aa4e18ff
Remove about:welcome Colorways code. r=omc-reviewers,hanna_a,fluent-reviewers,bolsson,emcminn

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6176aa4e18ff