Closed Bug 1828047 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39535 - Add the first test for basic text-box-trim functionality

Categories

(Core :: Layout: Block and Inline, task, P4)

Product:
Core
Component:
Layout: Block and Inline
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39535 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39535
Details from upstream follow.

Lingqi Chi <lingqi@chromium.org> wrote:

Add the first test for basic text-box-trim functionality

This PR adds the first functionality test for the text-box-trim property, to test the following points:

[1] The text-box-edge would be treated as "text" even if we do not specify a non-leading value.

For inline boxes: trims the block-start side of the box to match its content edge to the metric specified by text-box-edge (treating leading as text).

[2] Use the text's text-over/text-under baseline to generate the content box

Use the text-over baseline/text-under baseline.

[3] Since text-box-edge is not "leading" && this is not a root inline box(span does not create a root inline box), we do not need to perform half-leading here.

if text-box-edge is not leading and this is not the root inline box, if the half-leading is positive, treat it as zero.

[1] https://drafts.csswg.org/css-inline-3/#valdef-text-box-trim-start
[2] https://drafts.csswg.org/css-inline-3/#valdef-text-box-edge-text
[3] https://drafts.csswg.org/css-inline-3/#inline-height

preview:
https://github.com/Clqsin45/wpt/blob/demosets/linc-demo/text-box-trim/text-box-trim-basic-preview-v0.png

Component: web-platform-tests → Layout: Block and Inline
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Try push failed: decision task MP57sYNhRe6b1aualr_ZEA returned error

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8c2c3ae87734 [wpt PR 39535] - Add the first test for basic text-box-trim functionality, a=testonly https://hg.mozilla.org/integration/autoland/rev/df891de7ec77 [wpt PR 39535] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8c2c3ae87734
https://hg.mozilla.org/mozilla-central/rev/df891de7ec77

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.