1828076 - [wpt-sync] Sync PR 39531 - Don't update view transition style if DisplayLock is locked

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39531 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39531
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Don't update view transition style if DisplayLock is locked

There was no check to not update view transition pseudo elements if the
root element was locked for descendant style recalc by
content-visibility. That caused a DCHECK failure that such an element
should never be marked as having descendants that need layout tree
attachment.

Add !ShouldUpdateChildStyle() check to skip view transition style update
in that case.

Bug: 1429947
Change-Id: I89cd0b34deb7c318411382bf52f9300a50f12e2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422850
Reviewed-by: Vladimir Levin \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Code-Coverage: Findit \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1130325}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f3399c49e0e2a31ed03c4bec4a6f44d0dcbcdfa

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93e861a7b712
[wpt PR 39531] - Don't update view transition style if DisplayLock is locked, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/93e861a7b712