1828128 - MV3 extension cannot load when an empty web_accessible_resources list is in manifest.json

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Rob Wu [:robwu]]

web_accessible_resources is allowed to be an empty list in MV2 (and also in Chrome's MV3).

Firefox currently refuses to load the extension when an empty web_accessible_resources list is specified.

It even refuses to load if web_accessible_resources is specified, but matches or resources is an empty list. In bug 1809431 we updated the schema to allow an empty extension_ids list.
Chrome allows the extension to load with these set to an empty list, we should too.

Comment 1

[Rob Wu [:robwu]]

I found another issue - web_accessible_resources does not permit additional properties. That means that extensions with use_dynamic_url will fail to load (we haven't implemented use_dynamic_url yet, it's part of bug 1713196).

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1828128 - Relax required syntax for web_accessible_resources

• Do not require any item in the arrays

• Allow web_accessible_resources to have unrecognized properties instead
  of refusing to load the extension.

• Fix up minor quality issues in tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dfd444d61d4
Relax required syntax for  web_accessible_resources r=willdurand

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2dfd444d61d4