Closed Bug 1828225 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39564 - [GridNG] Add extra margins to a subgridded item's contribution size

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39564 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39564
Details from upstream follow.

Ethan Jimenez <ethavar@microsoft.com> wrote:

[GridNG] Add extra margins to a subgridded item's contribution size

  1. Introducing fields in NGGridLayoutTrackCollection to accumulate the
    start/end extra margin from subgrids, which will be used to compute
    the respective extra margin to be added to subgridded items.

    Also adding methods to compute the start/end extra margins to be
    applied to specific track spans within a track collection.

  2. Adding the start/end extra margin to a subgridded item's contribution
    size. This extra margin will accommodate any ancestor subgrid's
    margin, border, scrollbar, padding, and gutter size.

  3. Correcting an invalid definition for grid-column in the WPT test
    auto-track-sizing-001.html and its respective reference file.

Bug: 618969
Change-Id: I4c9c1264d91939b35a758afd00e081ed4d7bdb2e
Reviewed-on: https://chromium-review.googlesource.com/4421571
WPT-Export-Revision: c3466ade749523bdb28c91440d947da8072118ba

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5dbf6184acd [wpt PR 39564] - [GridNG] Add extra margins to a subgridded item's contribution size, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.