1828418 - Read brand files from fluent linter and lint for all brands, not just hardcoded list

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[:Gijs (he/him)]

I'm seeing that people forget to use brand names for things other than "Firefox", "Thunderbird" and "Mozilla", so it seems sensible to extend the brand list by actually reading the brandings file(s).

I have a local patch for this, but I've only tested it locally against a few single files, not against m-c, and also not against Thunderbird's repo. I assume the Thunderbird check is hardcoded for the same reasons as the Firefox one, and if we could point to the right brandings file, it could also go away, but I've kept it as-is for now.

Because of this, and because I'm not sure how to check for Thunderbird and/or if reading the browser/ brand file is even going to work in a TB repo, I'm going to ping some TB folks for reviews here as well.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1828418 - read brand files to determine what brands should be replaced in fluent files, r?flod!,rjl!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/624d3bb8be7a
read brand files to determine what brands should be replaced in fluent files, r=flod,rjl

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/624d3bb8be7a