1828434 - Remote Protocol markers missing from profiles generated by Raptor

Status: RESOLVED WORKSFORME

(Testing :: Raptor, defect, P2)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The markers introduced by bug 1818080 are not appearing in the profiles generated by Raptor.

Example recent page load regression bug with linked profiles that are missing the markers: https://bugzilla.mozilla.org/show_bug.cgi?id=1827282

Example profile showing the markers: https://profiler.firefox.com/public/fvm2zn3ekxwqsthn0t8ah4rvh6kwgwdfgrh89mg/marker-chart/?globalTrackOrder=0w2&markerSearch=Remote-Protocol&thread=0&v=8

This issue can be reproduced locally using the following command, which will run one page load and open the profile: ./mach raptor -t welcome --gecko-profile --page-cycles 1

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

(In reply to Dave Hunt [:davehunt] [he/him] ⌚GMT from comment #0)

This issue can be reproduced locally using the following command, which will run one page load and open the profile: ./mach raptor -t welcome --gecko-profile --page-cycles 1

I actually cannot see it locally when running the test on MacOS. The profile markers from Marionette are present. So I wonder what's different to your setup and especially the one that is used in CI.

Here my profile: https://share.firefox.dev/3GRdVUq

I tried to print the Marionette logs to the console but this doesn't work when setting the preference remote.log.level=Trace. Maybe the pref isn't correctly set via Raptor?

Comment 2

[Nazım Can Altınova [:canova]]

I also tried to reproduce this issue and I can't see those markers locally either, so +1 on Henrik's findings. Considering that we can see the "Marionette: Command" markers that are added in the same patch but not the others, I think it's very unlikely that only a subset of markers are missing.

I also tried to dump to terminal to see if these marker's codes are reached, but I can't see any of the dump messages I wrote, which supports the hypothesis that these markers don't have any problem. Probably we don't really have BiDi related code running at that point.

I would suggest that we close this bug.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Dave, can you please re-check?

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I don't see any "Remote-Protocol" markers with my original test:

./mach raptor -t welcome --gecko-profile --page-cycles 1

However, I do see them when I run a page load test:

./mach raptor -t google-docs --gecko-profile --page-cycles 1

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

I do perfectly see it for the welcome test: https://share.firefox.dev/3QGN1nt

Dave, did you maybe forgot to select the parent process? The markers are not present for web content processes.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Yep, I see it now. Thanks! Is the issue still present in our CI runs or should we close this as WORKSFORME?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

When I open a profile as generated for the Amazon (profiled) job on mozilla-central I can see the markers correctly. So I think that we can close this bug.