1828541 - Ensure we respect Ion's max script size setting when inlining in WarpOracle.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1828541 - Ensure we respect Ion's max script size setting r?iain

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/009b852b798d
Ensure we respect Ion's max script size setting r=iain

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/009b852b798d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta uplift, Doug?

Comment 5

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 9328945 [details]
Bug 1828541 - Ensure we respect Ion's max script size setting r?iain

Beta/Release Uplift Approval Request

• User impact if declined: Some scripts could cause Ion compile times and memory usage to explode a bit, most likely just negatively affecting performance. Unsure how common these scripts actually are, but likely fairly rare.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a very straightforward patch just limiting our ability to inline scripts in Ion if too much inlining has been happening already.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9328945 [details]
Bug 1828541 - Ensure we respect Ion's max script size setting r?iain

Approved for 113.0b8.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/258ac2f116da