1828677 - Invalid regex in BMO feed reader: `The regular expression you provided ':?:phab\\-bot[[:>:]]' is not valid`

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[Connor Sheehan [:sheehan]]

The BMO feed reader logs in Conduit suite are polluted by long stack traces for an invalid regex. The logs themselves are a bit tough to parse, but here is a section:

bmo.feed_1                  | STDERR: [undef] 2023/04/18 14:47:38  FATAL | Bugzilla.Extension.PhabBugz.Feed | The regular expression you provided ':?:phab\\-bot[[:>:]]' is not 
bmo.feed_1                  | valid. The error was: Illegal argument to a regular expression..                                                                                                
bmo.feed_1                  |  at Bugzilla/Error.pm line 99.                                                                                                                                  
bmo.feed_1                  |   Bugzilla::Error::_throw_error("global/user-error.html.tmpl", "illegal_regexp", HASH(0x55e7bc6812a8), CODE(0x55e7bc681d98)) called at Bugzilla/Error.pm line 17
5                                                                                              
bmo.feed_1                  |   Bugzilla::Error::ThrowUserError("illegal_regexp", HASH(0x55e7bc6812a8)) called at Bugzilla/DB.pm line 525                                                     bmo.feed_1                  |   Bugzilla::DB::bz_check_regexp(Bugzilla::DB::Mysql=HASH(0x55e7bc1d2168), "':?:phab\\\\-bot[[:>:]]'") called at Bugzilla/DB/Mysql.pm line 119
bmo.feed_1                  |   Bugzilla::DB::Mysql::sql_regexp(Bugzilla::DB::Mysql=HASH(0x55e7bc1d2168), "realname", "':?:phab\\\\-bot[[:>:]]'") called at /app/extensions/PhabBugz/lib/Feed.pm line 724                                    
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Feed::process_new_user(Bugzilla::Extension::PhabBugz::Feed=HASH(0x55e7bbb50870), HASH(0x55e7bc5ea4a0)) called at /app/extension
s/PhabBugz/lib/Feed.pm line 238                                                                                                                                                               
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Feed::__ANON__() called at Bugzilla/Util.pm line 76
bmo.feed_1                  |   Bugzilla::Util::with_readonly_database(CODE(0x55e7bc681710)) called at /app/extensions/PhabBugz/lib/Feed.pm line 239
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Feed::user_query(Bugzilla::Extension::PhabBugz::Feed=HASH(0x55e7bbb50870)) called at /app/extensions/PhabBugz/lib/Feed.pm line 57                                             
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Feed::__ANON__() called at Bugzilla/Util.pm line 60                                                               
bmo.feed_1                  |   Bugzilla::Util::try {...} () called at local/lib/perl5/Try/Tiny.pm line 102                                                         
bmo.feed_1                  |   eval {...} called at local/lib/perl5/Try/Tiny.pm line 93                                                                                                      
bmo.feed_1                  |   Try::Tiny::try(CODE(0x55e7bc65a3f0), Try::Tiny::Catch=REF(0x55e7bc65ad68)) called at Bugzilla/Util.pm line 68                          
bmo.feed_1                  |   Bugzilla::Util::with_writable_database(CODE(0x55e7bcb92ad0)) called at /app/extensions/PhabBugz/lib/Feed.pm line 58     
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Feed::try {...} () called at local/lib/perl5/Try/Tiny.pm line 102                                                             
bmo.feed_1                  |   eval {...} called at local/lib/perl5/Try/Tiny.pm line 93                                                                                                      
bmo.feed_1                  |   Try::Tiny::try(CODE(0x55e7bc681e28), Try::Tiny::Catch=REF(0x55e7bc681788), Try::Tiny::Finally=REF(0x55e7bc7dc6e8)) called at /app/extensions/PhabBugz/lib/Feed
.pm line 73                                                                                                                                                                                   
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Feed::run_query(Bugzilla::Extension::PhabBugz::Feed=HASH(0x55e7bbb50870), "user") called at /app/extensions/PhabBugz/lib/Feed.p
m line 106                                                                                                                                                                                    bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Feed::__ANON__(IO::Async::Timer::Periodic=HASH(0x55e7bbc34558)) called at local/lib/perl5/IO/Async/Notifier.pm line 838
bmo.feed_1                  |   IO::Async::Notifier::invoke_event(IO::Async::Timer::Periodic=HASH(0x55e7bbc34558), "on_tick") called at local/lib/perl5/IO/Async/Timer/Periodic.pm line 233
bmo.feed_1                  |   eval {...} called at local/lib/perl5/IO/Async/Timer/Periodic.pm line 233
bmo.feed_1                  |   IO::Async::Timer::Periodic::__ANON__(undef) called at local/lib/perl5/IO/Async/Internals/TimeQueue.pm line 107
bmo.feed_1                  |   IO::Async::Internals::TimeQueue::ARRAY__fire(IO::Async::Internals::TimeQueue=ARRAY(0x55e7bbc6ce48), 1681829258.168) called at local/lib/perl5/IO/Async/Interna
ls/TimeQueue.pm line 52
bmo.feed_1                  |   IO::Async::Internals::TimeQueue::fire(IO::Async::Internals::TimeQueue=ARRAY(0x55e7bbc6ce48)) called at local/lib/perl5/IO/Async/Loop.pm line 3111
bmo.feed_1                  |   IO::Async::Loop::_manage_queues(IO::Async::Loop::Poll=HASH(0x55e7bbc34ea0)) called at local/lib/perl5/IO/Async/Loop/Poll.pm line 187
bmo.feed_1                  |   IO::Async::Loop::Poll::post_poll(IO::Async::Loop::Poll=HASH(0x55e7bbc34ea0)) called at local/lib/perl5/IO/Async/Loop/Poll.pm line 292
bmo.feed_1                  |   IO::Async::Loop::Poll::loop_once(IO::Async::Loop::Poll=HASH(0x55e7bbc34ea0), undef) called at local/lib/perl5/IO/Async/Loop.pm line 538
bmo.feed_1                  |   IO::Async::Loop::run(IO::Async::Loop::Poll=HASH(0x55e7bbc34ea0)) called at /app/extensions/PhabBugz/lib/Feed.pm line 127
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Feed::start(Bugzilla::Extension::PhabBugz::Feed=HASH(0x55e7bbb50870)) called at /app/extensions/PhabBugz/lib/Daemon.pm line 97
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Daemon::gd_run(Bugzilla::Extension::PhabBugz::Daemon=HASH(0x55e7b3e18470)) called at local/lib/perl5/Daemon/Generic.pm line 192
bmo.feed_1                  |   Daemon::Generic::new("Bugzilla::Extension::PhabBugz::Daemon") called at local/lib/perl5/Daemon/Generic.pm line 37
bmo.feed_1                  |   Daemon::Generic::newdaemon() called at /app/extensions/PhabBugz/lib/Daemon.pm line 24
bmo.feed_1                  |   Bugzilla::Extension::PhabBugz::Daemon::start("Bugzilla::Extension::PhabBugz::Daemon") called at extensions/PhabBugz/bin/phabbugz_feed.pl line 22
bmo.feed_1                  |  at Bugzilla/Util.pm line 67.

Without this entry polluting the logs it would be much easier to spot code problems in BMO Feed reader in Suite.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1828677 - Invalid regex in BMO feed reader: `The regular expression you provided ':?:phab\\-bot[[:>:]]' is not valid` (#2052)

Comment 2

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/3066e4b2c27a79ea94ea2b9c16e0d4b363aa4baf