1828738 - Make it possible for about:welcome to open an FxA sign-in flow that closes itself after sign-in completes

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

One of the things we're hoping to do once the user has gotten to a new device is guide them through signing into their new Firefox Account.

Currently, when about:welcome opens up the FxA sign-in flow, a new tab opens, and the user signs in, and once sign-in completes, the user is taken to the FxA management webpage. The user is expected to manually switch back to about:welcome or to know to close the FxA management webpage to get back to the onboarding.

We might be able to do better. We could, for example, have the FxA sign-in tab be special such that when sign-in completes, we detect that it redirects to one of its final states, and we close it automatically. This is something we'll definitely want to run by the FxA/Sync team.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1828738 - Make it possible for about:welcome to close the FxA sign-in tab after sign-in completes. r?aminomancer!,jhirsch!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aee3d3aafb42
Make it possible for about:welcome to close the FxA sign-in tab after sign-in completes. r=aminomancer,jhirsch

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/aee3d3aafb42

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

Hi Mike! Could you please provide me with testing steps to verify this task? I didn't manage to see that the FxA sign-in tab closes after sign-in completes with the default settings.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hi Simona,

Do you have the ability to simulate ASRouter targeting parameters? What you need to be able to do is see the device migration onboarding screen, as it will present a "Sign in" button that will let you test the behaviour.

This is the ASRouter targeting parameter that needs to be true in order for you to see the new onboarding screen: https://searchfox.org/mozilla-central/rev/4e6970cd336f1b642c0be6c9b697b4db5f7b6aeb/browser/components/newtab/lib/ASRouterTargeting.jsm#974-978

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

Thanks @Mike for your reply! I managed to verify this task using the following steps:

1. Created an attributed Firefox installer: https://www.mozilla.org/firefox/all?utm_medium=migration&utm_content=QA-1828738&utm_campaign=migration&utm_source=qa
2. Downloaded and opened the latest Firefox Nightly 114.0a1 (Build ID: 20230507095340) from the above URL.
3. Navigated to the “about:welcome” page and clicked the “Sign in” button from the “Device Migration” screen.
4. Completed the Sign-in flow.
5. Observed that the “Signed in” page was dismissed and the focus was moved to the “about:welcome” page.

Considering this, I’m marking this task as Verified.