1828772 - Drop-down menus flickered when overlapping with the Find in page bar in Firefox 114.0a1 on Wayland

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Matt Fagnani]

Attachment: Recording of Firefox 114.0a1 (2023-04-18) showing the Comment drop-down menu flickering when overlapping the Find in Page bar

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

I started Firefox 114.0a1 20230418091934 on Wayland in Plasma 5.27.4 in a Fedora 38 KDE Plasma installation. I selected the Edit menu in the menu bar then Find in Page. I went to https://bugzilla.mozilla.org/query.cgi?format=advanced and https://bugs.kde.org/query.cgi?format=advanced I clicked on Detailed Bug Information I moved the page down so that the Comment drop-down box was shown downward such that it overlapped with the Find in Page bar at the bottom of Firefox. I clicked on the Comment drop-down box. I moved the cursor over the Comment box. I clicked on the Comment box's items multiple times. I repeated those steps with other drop-down boxes on those pages.

Actual results:

Drop-down menus flickered when overlapping with the Find in page bar and the cursor was moved over them in Firefox 114.0a1 on Wayland. Single-clicking on the menu items didn't select them, but the flickering usually stopped when doing so. I had to double-click on menu items in order to select them. I'm attaching a recording showing the problem.

114.0a1 20230411215906 didn't have this problem. 114.0a1 20230414161314 had the problem. I bisected using MOZ_ENABLE_WAYLAND=1 mozregression --launch 2023-4-14 --persist /tmp/mozregression

The first bad revision was for Bug 1826622 - [wayland] Ensure explicit popup constraints are honored.

15:18.65 INFO: Narrowed integration regression window from [eacfc6bf, 454a01f1] (3 builds) to [eacfc6bf, 421fca90] (2 builds) (~1 steps left)
15:18.65 INFO: No more integration revisions, bisection finished.
15:18.65 INFO: Last good revision: eacfc6bfd2eee8128a739fcdef08625c4976cdb3
15:18.65 INFO: First bad revision: 421fca90ff1272ab8bdb4965728833bc22eed3d7
15:18.65 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=eacfc6bfd2eee8128a739fcdef08625c4976cdb3&tochange=421fca90ff1272ab8bdb4965728833bc22eed3d7

This problem didn't happen with Firefox 114.0a1 20230418091934 on XWayland in the same environment.

Expected results:

The drop-down menus shouldn't have flickered when overlapping the Find in Page bar. Clicking once on a drop-down menu's item when its was overlapping the Find in Page bar should've selected it.

Comment 1

[Darkspirit]

(Matt Fagnani from comment #0)

I went to https://bugzilla.mozilla.org/query.cgi?format=advanced

so that the Comment drop-down box was shown downward such that it overlapped with the Find in Page bar at the bottom of Firefox. I clicked on the Comment drop-down box. I moved the cursor over the Comment box.

Reproduced on KDE Wayland, Debian Testing.

(Edit: Don't panic, I was able to put bug 1826622 into the Regressed By field although I can't access it.)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1828772 - Don't use move-to-rect if layout has flipped our popup. r=stransky

As move-to-rect wouldn't account for those constraints.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60d2bbf29375
Don't use move-to-rect if layout has flipped our popup. r=stransky

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out the regressing change from Beta for 113.0b6.
https://hg.mozilla.org/releases/mozilla-beta/rev/00880b627650

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/60d2bbf29375