182879 - collapsing borders: top border on cell with colspan in tfoot disappears

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[mcknzm]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2) Gecko/20021126
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2) Gecko/20021126

If stylesheet defines border-top for th in tfoot, and that th element uses
colspan  then border is drawn only for first column width, not full width.
Please see added URL for an example page.

Reproducible: Always

Steps to Reproduce:
1. Define this in stylesheet: tfoot th { border-top: 1px solid black; }
2. Create a table with some columns and tfoot with th and use colspan:
   <table>
   <tfoot><tr><th colspan="3">footer</th></tr></tfoot>
   <tbody><tr><td>1</td><td>2</td><td>3</td>
   </table>
3. See that page in Mozilla.

Actual Results:  
Border is drawn only for the width of column 1.

Expected Results:  
Mozilla should have drawn the border for the full with of columns as defined by
th element's colspan.

Comment 1

[José Jeria]

Attachment: Reporters testcase

Comment 2

[José Jeria]

Sorry, forget the testcase, didnt see the URL.

What causes the incorrect border is:
border-collapse: collapse;

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

->tables

Comment 4

[Brian Kavanaugh]

Attachment: Basic table showing border-top not working right in footer

Comment 5

[Bernd]

Attachment: patch

the patch fixes the problem in attachment 113249 [details] I dont see the problem in the
URL

Comment 6

[John Keiser (jkeiser)]

Comment on attachment 113807 [details] [diff] [review]
patch 

r=me, but it's gross that we have to access CellMap instead of TableCellMap
here in the first place.

Comment 7

[Bernd]

otherwise you would have to search again for the cellmap for every table cell,
that would be a performance problem

Comment 8

[Bernd]

fixed together with bug 157047