1828860 - Reduce frequent warnings from ConduitClosed

Status: RESOLVED DUPLICATE of bug 1839637

(WebExtensions :: General, task, P3)

Description

[Jens Stutte [:jstutte]]

There are frequent warnings in our treeherder log files like:

[task 2023-04-19T07:39:36.955Z] 07:39:36     INFO - PID 964 | [Child 6348, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:57

Most likely they come from here.

I am not familiar with actors in JS, but I assume we can check some equivalent of CanSend() before trying to send it? It might also be that didDestroy should call Close with a flag that does not try to send back something, given we are already destroyed? No, that is already the case with silent.

Comment 1

[Connor Sheehan [:sheehan]]

This Conduit component refers to the developer infrastructure used for Firefox development (Phabricator, Lando, etc). Moving to a component that is likely closer to the correct one.

Comment 2

[Jens Stutte [:jstutte]]

Thanks and sorry for the noise, actually the message generating JS is apparently part of WebExtensions.

Comment 3

[Jens Stutte [:jstutte]]

Attachment: WIP: Bug 1828860 - Avoid multiple ConduitClosed messages.

Comment 5

[Jens Stutte [:jstutte]]

Note that bug 1832242 reduces the unintentional spam in non-DEBUG builds.

Comment 6

[Kris Maglione [:kmag]]

(In reply to Nika Layzell [:nika] (ni? for response) from bug 1830445 comment #3)

The Conduits actor is from WebExtensions, so moving this over there. This error just means that the actor is dead, and WebExtensions conduits are trying to send the ConduitClosed message over them.

The calling code even does an empty catch block around the send call, so perhaps it should just check if the actor is still alive before sending: https://searchfox.org/mozilla-central/rev/445a5ab684b73eb56d807d0f3b2fabcc85a7c3dd/toolkit/components/extensions/ConduitsChild.jsm#136

Comment 7

[Jens Stutte [:jstutte]]

(In reply to Kris Maglione [:kmag] from comment #6)

(In reply to Nika Layzell [:nika] (ni? for response) from bug 1830445 comment #3)

The Conduits actor is from WebExtensions, so moving this over there. This error just means that the actor is dead, and WebExtensions conduits are trying to send the ConduitClosed message over them.

The calling code even does an empty catch block around the send call, so perhaps it should just check if the actor is still alive before sending: https://searchfox.org/mozilla-central/rev/445a5ab684b73eb56d807d0f3b2fabcc85a7c3dd/toolkit/components/extensions/ConduitsChild.jsm#136

This code now moved here, but is still the same.