1828910 - Perma [tier2] dom/base/test/fullscreen/test_fullscreen-api.html | Test timed out

Status: RESOLVED DUPLICATE of bug 1823284

(Core :: DOM: Core & HTML, defect)

Description

[Treeherder Bug Filer]

Filed by: chorotan [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=412981460&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TinlUCH-QGmYoccW9eQGHA/runs/0/artifacts/public/logs/live_backing.log

---

task 2023-04-19T10:09:58.476Z] 10:09:58     INFO - TEST-PASS | dom/base/test/fullscreen/test_fullscreen-api.html | reftest comparison: == snapshot green 
[task 2023-04-19T10:09:58.476Z] 10:09:58     INFO - Waiting for focus to return to main window
[task 2023-04-19T10:09:58.477Z] 10:09:58     INFO - testWindow.close()
[task 2023-04-19T10:09:58.478Z] 10:09:58     INFO - main window focused, starting next test
[task 2023-04-19T10:09:58.478Z] 10:09:58     INFO - Run test file_fullscreen-resize.html
[task 2023-04-19T10:09:58.479Z] 10:09:58     INFO - Buffered messages logged at 10:05:27
[task 2023-04-19T10:09:58.479Z] 10:09:58     INFO - Were focused
[task 2023-04-19T10:09:58.480Z] 10:09:58     INFO - [resize] Entered fullscreen
[task 2023-04-19T10:09:58.481Z] 10:09:58     INFO - Buffered messages finished
[task 2023-04-19T10:09:58.482Z] 10:09:58     INFO - TEST-UNEXPECTED-FAIL | dom/base/test/fullscreen/test_fullscreen-api.html | Test timed out. - 
[task 2023-04-19T10:09:59.215Z] 10:09:59     INFO - GECKO(1580) | MEMORY STAT | vsize 2696MB | residentFast 161MB | heapAllocated 8MB
[task 2023-04-19T10:09:59.493Z] 10:09:59     INFO - TEST-OK | dom/base/test/fullscreen/test_fullscreen-api.html | took 314900ms
[task 2023-04-19T10:10:02.505Z] 10:10:02     INFO - Error: Unable to restore focus, expect failures and timeouts.

Comment 1

[Cristina Horotan [:chorotan]]

Brad, could your push cause this failure? It is perma failing only on central.

Comment 2

[Brad Werth [:bradwerth]]

(In reply to Cristina Horotan [:chorotan] from comment #1)

Brad, could your push cause this failure? It is perma failing only on central.

Yes, that's very likely. Didn't see it in my try runs but I'll keep working on the patch stack in Bug 1826645 until I'm sure it's passing. Feel free to backout the changes.

Comment 3

[Brad Werth [:bradwerth]]

(In reply to Brad Werth [:bradwerth] from comment #2)

Yes, that's very likely. Didn't see it in my try runs but I'll keep working on the patch stack in Bug 1826645 until I'm sure it's passing. Feel free to backout the changes.

Or since this is Tier 2, don't backout the changes and I'll build the fix here.

Comment 4

[Brad Werth [:bradwerth]]

The failure is that we're bailing out of an exit fullscreen because of events/requests arriving in an unexpected order. This is what Bug 1826645 was trying to address, but we evidently have another mode of error. I'll find a fix.

Comment 5

[Brad Werth [:bradwerth]]

I can get the file_fullscreen-resize.html part of the test to fail locally on macOS while running in headless mode. I'll see if I can make the test pass in these circumstances.

Comment 6

[Intermittent Failures Robot]

37 failures in 779 pushes (0.047 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 37

Platform and build breakdown:

• linux1804-64-qr: 14
  • debug: 14
• linux1804-64-tsan-qr: 6
  • opt: 6
• linux1804-64-asan-qr: 5
  • opt: 5
• linux1804-64-ccov-qr: 6
  • opt: 6
• linux1804-64-shippable-qr: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1828910&startday=2023-04-19&endday=2023-04-19&tree=all

Comment 7

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Since the test fails on headless widget only, maybe somehow headless widget behave different than other platforms (?), if that is the case, we could also consider making headless widget behave the same as other platforms if possible.

Comment 8

[Brad Werth [:bradwerth]]

Attachment: Bug 1828910: Make HeadlessWidget invoke FullscreenWillChange on its listener.

NSGlobalWindowOuter is the listener to HeadlessWidget. It maintains
internal fullscreen state which is checked in FinishFullscreenChange. It
is necessary for the widget to first call FullscreenWillChange in order to
have expected state before the call to FinishFullscreenChange.

Comment 9

[Brad Werth [:bradwerth]]

The fix for this issue will depend largely on Bug 1823284. If that Bug removes the FullscreenWillChange listener method, then this Bug will need some other kind of fix to maintain the internal state in NSGlobalWindowOuter.

Comment 10

[Intermittent Failures Robot]

18 failures in 779 pushes (0.023 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 18

Platform and build breakdown:

• linux1804-64-qr: 7
  • debug: 7
• linux1804-64-asan-qr: 2
  • opt: 2
• linux1804-64-ccov-qr: 4
  • opt: 4
• linux1804-64-tsan-qr: 1
  • opt: 1
• linux1804-64-shippable-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1828910&startday=2023-04-20&endday=2023-04-20&tree=all

Comment 11

[Intermittent Failures Robot]

15 failures in 158 pushes (0.095 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 15

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 2
• linux1804-64-tsan-qr: 2
  • opt: 2
• linux1804-64-asan-qr: 2
  • opt: 2
• linux1804-64-ccov-qr: 5
  • opt: 5
• linux1804-64-shippable-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1828910&startday=2023-04-22&endday=2023-04-22&tree=all

Comment 12

[Intermittent Failures Robot]

92 failures in 4004 pushes (0.023 failures/push) were associated with this bug in the last 7 days.

This is the #6 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 92

Platform and build breakdown:

• linux1804-64-qr: 27
  • debug: 27
• linux1804-64-tsan-qr: 14
  • opt: 14
• linux1804-64-asan-qr: 12
  • opt: 12
• linux1804-64-ccov-qr: 21
  • opt: 21
• linux1804-64-shippable-qr: 18
  • opt: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1828910&startday=2023-04-17&endday=2023-04-23&tree=all

Comment 13

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Bug 1823284 should also fix this.

Comment 14

[Brad Werth [:bradwerth]]

Indeed, fixed by the patches in Bug 1823284.