1828950 - wdspec fetch helper throws when used twice in the same test

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Julian Descottes [:jdescottes]]

The new fetch helper is

        await bidi_session.script.evaluate(
            expression=f"""
                 const controller = new AbortController();
                 setTimeout(() => controller.abort(), {timeout_in_seconds * 1000});
                 fetch("{url}", {{
                   {method_arg}
                   {headers_arg}
                   signal: controller.signal
                 }}).then(response => response.text());""",
            target=ContextTarget(context["context"]),
            await_promise=True,
        )

This leads to errors in tests which use the helper twice on the same page.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1828950 - [wdspec] Use a block scope in fetch helper expression

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826819

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f57ebd57eee
[wdspec] Use a block scope in fetch helper expression r=webdriver-reviewers,whimboo

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39625 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2f57ebd57eee

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot