1828995 - [wpt-sync] Sync PR 39610 - Re-layout writing-mode roots on ICB size change, when needed.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39610 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39610
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Re-layout writing-mode roots on ICB size change, when needed.

The inline-size of an orthogonal writing-mode root may depend on the
size of the initial containing block.

This hasn't worked flawlessly for some time (ever?). We have
orthogonal_writing_mode_root_list_ in LocalFrameView, and when the
viewport size changes, we should go through that list and mark
everything for layout. However, this will only happpen when
StyleResolver::WasViewportResized() is true, which is only triggered if
the document has any element with viewport units. That's probably
fixable, so that the flag is always set when needed.

But since orthogonal_writing_mode_root_list_ is less useful anyway with
the legacy engine gone, we're going to remove it. So here's a different
solution, purely on the layout side.

Change-Id: I7754ad87f881ba6569fc27065641a9c809e8ef86
Reviewed-on: https://chromium-review.googlesource.com/4447584
WPT-Export-Revision: 054cc3695bb0fda72baa2bdba2f29ce6f9cb7825

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cad31d059b394116582b8c66baaeb5ae5b9c85b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task L7_6tzDnTNeGk44uYGke_w returned error

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task PdPdL1BmRcSsyTs__CrQ5g returned error

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task FYkCHCaXSC-IJ08fIqZx-w returned error

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfcf8c41530f65c5c445e333f1dda2e1531efe32

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests

Status Summary

Firefox

FAIL: 7

Chrome

FAIL: 7

Safari

FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-writing-modes/orthogonal-root-resize-icb-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-writing-modes/orthogonal-root-resize-icb-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-writing-modes/orthogonal-root-resize-icb-003.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-writing-modes/orthogonal-root-resize-icb-004.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-writing-modes/orthogonal-root-resize-icb-005.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-writing-modes/orthogonal-root-resize-icb-006.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-writing-modes/orthogonal-root-resize-icb-007.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/697149b5a98b
[wpt PR 39610] - Re-layout writing-mode roots on ICB size change, when needed., a=testonly
https://hg.mozilla.org/integration/autoland/rev/f28033ec2491
[wpt PR 39610] - Update wpt metadata, a=testonly

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/697149b5a98b
https://hg.mozilla.org/mozilla-central/rev/f28033ec2491