1829016 - Changing width/height of an element inside auto-sized `content-visibility: auto` container does not update the container's width/height

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Shin[:dshin]]

Attachment: Minimum Reproducible Case

STR: Load attached test case, click on "Click" div
Expected Result: Hello\nThere renders below the "Click" div within the border.
Actual Result: Nothing changes, until the window is resized. Clicking the "Click" div again hides Hello\nThere but the space remains until the window is resized.

Reduced from https://docs-os.mainsail.xyz/change-wifi-credentials

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1820058

:dholbert, since you are the author of the regressor, bug 1820058, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: testcase 2

Here's a variant of the original testcase here.

Notable differences:

• now the width toggles as well (with no visible effect); so we have this bug in both axes, not just 'height'.
• I removed the zero width and visibility:hidden to avoid the possibility of any zero/non-rendering special case being tripped.
• I pulled the clickable div out of the content-visibility:auto container so that it just contains the thing whose size is changing, for simplicity.

Comment 3

[Daniel Holbert [:dholbert]]

One other interesting note: as noted in comment 0, resizing the window does seem to fix height discrepancies, but not width discrepancies!

In particular:
(1) Load testcase 2.
(2) Click the "click" target.
--> Firefox changes the background-color from orange to lime (yay!) but doesn't resize the black-bordered box.
(3) Change the width of your browser window.
--> Firefox belatedly updates the height of the black-bordered box to 100px (yay!) but does not update its width. I'm not sure what if any user-exposed nudges will prompt us to update the width, aside from using devtools to temporarily disable & re-enable the content-visibility:auto declaration.

(The expected result is that we should be resizing the black-bordered box to 100x100 after step 2.)

Shot in the dark: I imagine we need MarkIntrinsicISizesDirty to be called on the container in this case, and it normally would be, but content-visibility:auto is suppressing that somehow?

Comment 4

[Daniel Holbert [:dholbert]]

Tentatively calling this S2 since this seems like a pretty big potential source of brokenness in content-visibility:auto, and the user impact is likely to involve missing/invisible content rather than just cosmetic problems. (And we know of at least one affected site, per comment 0.)

Comment 5

[Frank Griffith Jr]

Dropping to an S3 as this is Nightly Only

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1820058

Comment 7

[cathiechen]

Attachment: Bug 1829016 - The size of content-visibility auto does not refresh when its content changes, r?emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a86390266ae9
The size of content-visibility auto does not refresh when its content changes, r=emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41175 for changes under testing/web-platform/tests

Comment 10

[Iulian Moraru]

Backed out for causing wr failures on content-visibility-085.html.

• Push with failures

• Failure log

• Backout link

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af8f747d83ec
The size of content-visibility auto does not refresh when its content changes, r=emilio

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/af8f747d83ec

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:cathiechen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.Also, don't forget to request an uplift for the patches in the regression caused by this fix.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[cathiechen]

I don't think it needs an uplift, for it only affects content-visibility, which is not enabled by default yet.

Not sure how to set the status-firefox117 to wontfix, I can only see these 3 options ---, ? and affected.

Comment 16

[cathiechen]

Thanks a lot, Mirko:)

Comment 17

[Daniel Holbert [:dholbert]]

updating the status to disabled (despite what BugBot said) since the feature is disabled by default beyond Nightly (per comment 15).

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot