1829108 - Remove Utility specific timeout

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Comment 1

[:gerard-majax]

Attachment: Bug 1829108 - Use similar to IPC timeout for Utility LaunchTimeout r?#ipc-reviewers!

Comment 2

[:gerard-majax]

Attachment: WIP: Bug 1829108 - Reproducer

Trying to repro:

• make BaseProcessLauncher::PerformAsyncLaunch() wait X ms before self->FinishLaunch()
• make UtilityProcessHost::LaunchTimeout wait Y ms before calling a timeout
• make sure Y << X (e.g. 1ms VS 500ms)
• this should trigger LaunchTimeout
• UtilityProcessManager::StartRemoteDecodingUtilityPromise rejection code should not think we are in shutdown
• MOZ_LOG=timestamp,utilityproc:5 BUILD_DEBUG=1 ./mach test --headless dom/media/webaudio/test/test_decodeAudioDataPromise.html
• Utility process should not have enough time to go through OnChannelConnect

Comment 3

[:gerard-majax]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1827894#c12 there is no evidence we have any other problem here besides the system just taking several seconds to create the process.

Comment 4

[:gerard-majax]

Attachment: Bug 1829108 - Remove Utility specific launch timeout and rely on IPC timeouts r?#ipc-reviewers!

Comment 5

[:gerard-majax]

Attachment: Bug 1829108 - Relax assertions on UtilityProcessManager r?#ipc-reviewers!

Depends on D177281

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fd3cc93a75d
Remove Utility specific launch timeout and rely on IPC timeouts r=ipc-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/f7e66a495369
Relax assertions on UtilityProcessManager r=ipc-reviewers,nika

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1fd3cc93a75d
https://hg.mozilla.org/mozilla-central/rev/f7e66a495369