1829366 - Downloading PDFs is unintuitive on android

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Marco Castelluccio [:marco]]

+++ This bug was initially created as a clone of Bug #1823164 +++

We have decided on a slightly different solution to bug 1823164.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [GeckoView] Change the toolbar for a static one on the top of the viewer (bug 1829366) (#16340)

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1829366 - Enable the new PDF.js toolbar on GeckoView r=#geckoview-reviewers

Comment 3

[Calixte Denizet (:calixte)]

Attachment: Bug 1829366 - Add a toolbar with a download button in pdf.js in GeckoView r=#pdfjs-reviewers,#geckoview-reviewers

Comment 4

[Calixte Denizet (:calixte)]

Comment on attachment 9330026 [details]
Bug 1829366 - Add a toolbar with a download button in pdf.js in GeckoView r=#pdfjs-reviewers,#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: The way to download a pdf on Fenix is not really user-friendly right now and this patch will help to make it a way better.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - check that there's a toolbar with a Download button on the top of the pdf viewer

• open a pdf in Fenix
• tap the button "Download" and the pdf should be saved in the Downloads folder on the device

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a small change.
  The toolbar itself has been introduced in nightly few days ago with no specific issues and we just changed the css today to make more friendly with the help UI/UX team.
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/734186ff0bc5
Enable the new PDF.js toolbar on GeckoView r=geckoview-reviewers,amejiamarmol

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/734186ff0bc5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9329975 [details]
Bug 1829366 - Enable the new PDF.js toolbar on GeckoView r=#geckoview-reviewers

Approved for 113.0b8.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c64dd161646
https://hg.mozilla.org/releases/mozilla-beta/rev/bd71346722a1

Comment 9

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 114.0a1 and Beta 113.0b8.
Devices used:

Oneplus 5 (Android 10)
OnePlus A3000 (Android 6)
Lenovo Tab P11 Plus (Android 12)
Lenovo tab M10 (Android 10)
Xiaomi 12 Pro (Android 13)
Huawei MediaPad M2 (Android 5.1.1)
Google Pixel 7 (Android 13)

Comment 10

[Adina Petridean QA [:apetridean]]

Attachment: download.mp4

Comment 11

[Calixte Denizet (:calixte)]

:Adina, could you check that it's fine with a device with a low-resolution screen ?

Comment 12

[Adina Petridean QA [:apetridean]]

:Calixte, we've also checked this issue on devices with low-resolution screens using the latest Nightly 114.0a1 from 26.04.2023 and Firefox 113.0b8.

Devices used:
Xperia 10 (Android 12)
Samsung Galaxy S9 (Android 8)
OnePlus A3000 (Android 6)