182946 - fix regressions from bug 171493 (Bug.pm/show_bug.cgi/bug_form.pl reorg)

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Dave Miller [:justdave]]

On bugzilla-tip, any changes submitted to a bug clears the cc_accessible flag on
that bug.

I'm not flagging this as security because this results in an installation which
is potentially more secure than you want, rather than less secure.

Comment 1

[Dave Miller [:justdave]]

OK, more research shows the value does get put into the database according to
what's on the form, however, the form is always getting pre-populated with the
checkbox empty, regardless of the existing value.  This suggests either the
template is pulling the wrong value or the new Bug.pm isn't loading it...

Comment 2

[Bradley Baetz (:bbaetz)]

Oh, yeah, umm.

I noticed this yesterday. Fixed in the patch for bug 158499, as well as a few
other minor issues.

Fix is to s/./,/ in Bug.pm, where we pull stuff out of the DB. 'oops'. If that
doesn't get reviewed today, I'll pull out the regression fixes separately.

Comment 3

[Bradley Baetz (:bbaetz)]

Attachment: fix regressions

This should fix:

- cclist_accessible always reported |undef| ('.' instead of ',')
- the js for changing the assignee was wrong (assigned_to_email vs
assigned_to.email, from a previous iteraton)
- blocking bugs weren't shown - this was another case of xml vs show_bug having

different field names. I changed Bug.pm (and thus the xml output), because it
was easier than also changing process_bug.
- There was an extra </a> for the target milestone milestoneurl link

I pulled this out of the patch for bug 158499

Comment 4

[Bradley Baetz (:bbaetz)]

-> me, and changing summary - I suspect that more people will notice blockers
being removed anyway ;)

Comment 5

[Bradley Baetz (:bbaetz)]

Fixed

Comment 6

[Bradley Baetz (:bbaetz)]

I also checked in a one-line typo-fix in Bug.pm pointed out on irc by tm:

-  $self->{'any_flags_requesteeable'} = grep($_->{'is_requesteeble'}, @$flag_types);
+  $self->{'any_flags_requesteeble'} = grep($_->{'is_requesteeble'}, @$flag_types);

Comment 7

[Joel Peshkin]

*** Bug 183529 has been marked as a duplicate of this bug. ***