1829493 - [Wayland] Consider removing idle vsync timer

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Bug 1786247 introduced an idle vsync timer to not hold on to resources indefinitely on throttled windows. We should've fixed the root cause of it in bug 1828587, so maybe we can remove it now.

Martin, Robert, wdyt? Is there any other reason we'd need the idle timer?

Comment 1

[Robert Mader [:rmader]]

IIUC you are talking about us currently sticking to 1Hz minimum, right? I'd be totally in favor for getting rid of it if possible.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Emilio I don't have strong opinion here and I'm ok with that as far as it doesn't break anything. Also that's Wayland only stuff right? As we don't have a idle state detection on X11.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to Robert Mader [:rmader] from comment #1)

IIUC you are talking about us currently sticking to 1Hz minimum, right? I'd be totally in favor for getting rid of it if possible.

Correct.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #2)

Emilio I don't have strong opinion here and I'm ok with that as far as it doesn't break anything. Also that's Wayland only stuff right? As we don't have a idle state detection on X11.

Correct as well.

Ok can try to send a patch and see how it goes.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1829493 - [wayland] Don't keep firing vsync at idle rate once idle. r=stransky,rmader

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1829493 - [wayland] Misc WaylandVsyncSource clean-ups. r=stransky,rmader

Improve naming of some of the variables, remove some redundant type
params, and avoid calling TimeStamp::Now() unnecessarily, which is not
free.

Depends on D176282

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d43bc8b81921
[wayland] Don't keep firing vsync at idle rate once idle. r=rmader
https://hg.mozilla.org/integration/autoland/rev/8da3f82245ac
[wayland] Misc WaylandVsyncSource clean-ups. r=rmader

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d43bc8b81921
https://hg.mozilla.org/mozilla-central/rev/8da3f82245ac