1829494 - Consider adding an AWSY test with minimized windows running animations / with an animated theme

Status: NEW

(Testing :: AWSY, enhancement, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

This would've caught bug 1828587. Not something very easy to foresee, arguably, but it might be worth to confirm we don't regress memory usage / memory usage grows a lot in that kind of scenario.

Comment 1

[Andrew McCreight [:mccr8]]

We've had a similar kind of issue at least once before, so a test would be good. I think I remember Matt Woodrow fixing some kind of leak that was caused if you minimized a window while it was playing video. I think it was something like the first half of some compositor pipeline kept shoving stuff in, but the second half wasn't pulling anything out, so memory just kept building up. Definitely the kind of thing that can go wrong very quickly. This was many years ago, of course.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah, that's effectively what happened in the bug above. This also happened not so long ago on Wayland too (see bug 1786247), though we don't have automated tests for Wayland yet (bug 1725245), so this would not have helped...

I think having a minimized window with a foreground tab that runs:

• CSS animations.
• Image animations.
• Plays a video.
• Maybe some audio too.

Would cover most of the interesting cases. Bonus points for having an animated theme while running this test (since that causes the leak in the parent process which is worse)...

But yeah if we could get this set up it'd be great.

Comment 3

[Andrew McCreight [:mccr8]]

Should it be an AWSY test that is tracked in perfherder? That would mean that regressing a metric, tracked by PerfHerder, by 1% or whatever would get your patch backed out. It feels like we really want more of a smoke test that makes sure memory usage doesn't increase by a large amount in a minimized or occluded window.