1829544 - The keyboard shortcut for Restart (Developer) conflicts with the shortcut for Enter Reader View

Status: UNCONFIRMED

(DevTools :: General, defect, P3)

Description

[Graham Perrin]

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:109.0) Gecko/20100101 Firefox/112.0

Steps to reproduce:

1. show the menu bar

2. visit a page that supports reader view, for example https://forum.gitlab.com/t/refreshing-a-fork/32469

3. in the View menu, observe Enter Reader View with keyboard shortcut Ctrl+Alt+R

4. use the shortcut

Actual results:

5. Firefox restarts

6. in the File menu, observe the same shortcut used for Restart (Developer

Expected results:

5. reader view.

Comment 1

[Graham Perrin]

See also:

• Firefox: Restart (Developer) Ctrl-Alt-R conflict with Enter Reader View with the same shortcut : freebsd (2020-12-13), in particular an end user report of the same bug on Ubuntu
• FreeBSD bug 251817 – www/firefox Ctrl-Alt-R should enter Reader view, should not restart Firefox

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Reader Mode' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Alexandre Poirot [:ochameau]]

It sounds like FreeBSD is building firefox with MOZ_OFFICIAL variable is false.
I imagine it is an explicit choice to prevent shipping with official branding.

Unfortunately, the Ctrl+Alt+R keyshortcut, which is only meant to ship in development builds is being gated by MOZ_OFFICIAL:
https://searchfox.org/mozilla-central/rev/8329a650e3b4f866176ae54016702eb35fb8b0d6/browser/base/content/browser.xhtml#108-110
It isn't clear if we could pick some other condition.
But we could add an additional condition to ease supporting FreeBSD builds.

Do you know if there would be a good alternative variable to check for official, FreeBSD builds?