1829581 - Remove nsNavHistory::URIToResultNode()

Attachment #9343851 - Attachment description: Bug 1829581: Remove nsNavHistory::URIToResultNode() → Bug 1829581: Avoid using URIToResultNode() in OnTitleChanged()

Daisuke Akatsuka (:daisuke)

Assignee

Comment 2

•

1 year ago

Attached file Bug 1829581: Stop using URIToResultNode() in OnItemTagsChanged() (obsolete) — Details

Depends on D183567

Phabricator Automation

Updated

•

1 year ago

Attachment #9343851 - Attachment description: Bug 1829581: Avoid using URIToResultNode() in OnTitleChanged() → Bug 1829581: Stop using URIToResultNode() in OnTitleChanged()

Phabricator Automation

Updated

•

1 year ago

Attachment #9344527 - Attachment description: Bug 1829581: Avoid using URIToResultNode() in OnItemTagsChanged() → Bug 1829581: Stop using URIToResultNode() in OnItemTagsChanged()

Phabricator Automation

Updated

•

1 year ago

Attachment #9343851 - Attachment description: Bug 1829581: Stop using URIToResultNode() in OnTitleChanged() → Bug 1829581: Stop using URIToResultNode()

Phabricator Automation

Updated

•

1 year ago

Attachment #9344527 - Attachment is obsolete: true

Marco Bonardo [:mak]

Updated

•

1 year ago

Blocks: 1821664

No longer depends on: 1821664

Daisuke Akatsuka (:daisuke)

Assignee

Updated

•

1 year ago

Blocks: 1846361

Pulsebot

Comment 3

•

1 year ago

Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d027c88d075e Stop using URIToResultNode() r=mak

Iulian Moraru

Comment 4

•

1 year ago

Backed out for causing AddressSanitizer failures on xpcshell jobs.
So far, this only happened on Linux 18.04 x64 WebRender asan opt.

[task 2023-08-01T03:09:59.841Z] 03:09:59     INFO -  TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js | took 1108ms
[task 2023-08-01T03:09:59.843Z] 03:09:59     INFO -  Retrying tests that failed when run in parallel.
[task 2023-08-01T03:09:59.844Z] 03:09:59     INFO -  TEST-START | toolkit/components/places/tests/queries/test_results-as-visit.js
[task 2023-08-01T03:10:00.955Z] 03:10:00  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/queries/test_results-as-visit.js | xpcshell return code: 1
[task 2023-08-01T03:10:00.955Z] 03:10:00     INFO -  TEST-INFO took 1108ms
[task 2023-08-01T03:10:00.955Z] 03:10:00     INFO -  >>>>>>>
[task 2023-08-01T03:10:00.955Z] 03:10:00     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-08-01T03:10:00.956Z] 03:10:00     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-08-01T03:10:00.956Z] 03:10:00     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-08-01T03:10:00.956Z] 03:10:00     INFO -  running event loop
[task 2023-08-01T03:10:00.956Z] 03:10:00     INFO -  toolkit/components/places/tests/queries/test_results-as-visit.js | Starting test_results_as_visit
[task 2023-08-01T03:10:00.956Z] 03:10:00     INFO -  (xpcshell/head.js) | test test_results_as_visit pending (2)
[task 2023-08-01T03:10:00.956Z] 03:10:00     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-08-01T03:10:00.957Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2023-08-01T03:10:00.957Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) 1690859400099	places	TRACE	FrecencyRecalculator :: Initializing Frecency Recalculator"
[task 2023-08-01T03:10:00.957Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) 1690859400100	places	TRACE	FrecencyRecalculator :: Arm frecency recalculation"
[task 2023-08-01T03:10:00.958Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) 1690859400104	places	TRACE	FrecencyRecalculator :: Got places-init-complete topic"
[task 2023-08-01T03:10:00.958Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) 1690859400105	places	TRACE	FrecencyRecalculator :: Got frecency-recalculation-needed topic"
[task 2023-08-01T03:10:00.959Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) 1690859400105	places	TRACE	FrecencyRecalculator :: Frecency recalculation requested"
[task 2023-08-01T03:10:00.959Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) 1690859400105	places	TRACE	FrecencyRecalculator :: Arm frecency recalculation"
[task 2023-08-01T03:10:00.960Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) 1690859400110	places	TRACE	FrecencyRecalculator :: Clean up alternative frecency of pages"
[task 2023-08-01T03:10:00.961Z] 03:10:00     INFO -  "CONSOLE_MESSAGE: (info) 1690859400128	places	TRACE	FrecencyRecalculator :: Clean up alternative frecency of origins"
[task 2023-08-01T03:10:00.962Z] 03:10:00     INFO -  "Number of items in result set: 15"
[task 2023-08-01T03:10:00.962Z] 03:10:00     INFO -  "result: http://foo.com/ Title: amo"
[task 2023-08-01T03:10:00.962Z] 03:10:00     INFO -  "result: http://foo.com/ Title: amo"
[task 2023-08-01T03:10:00.962Z] 03:10:00     INFO -  "result: http://foo.com/ Title: amo"
[task 2023-08-01T03:10:00.962Z] 03:10:00     INFO -  "result: http://moilla.com/ Title: bMoz"
[task 2023-08-01T03:10:00.962Z] 03:10:00     INFO -  "result: http://moilla.com/ Title: bMoz"
[task 2023-08-01T03:10:00.963Z] 03:10:00     INFO -  "result: http://moilla.com/ Title: bMoz"
[task 2023-08-01T03:10:00.963Z] 03:10:00     INFO -  "result: http://moilla.com/ Title: bMoz"
[task 2023-08-01T03:10:00.963Z] 03:10:00     INFO -  "result: http://moilla.com/ Title: bMoz"
[task 2023-08-01T03:10:00.963Z] 03:10:00     INFO -  "result: http://foo.mail.com/changeme1.html Title: c Moz"
[task 2023-08-01T03:10:00.963Z] 03:10:00     INFO -  "result: http://foo.mail.com/changeme1.html Title: c Moz"
[task 2023-08-01T03:10:00.964Z] 03:10:00     INFO -  "result: http://foo.mail.com/changeme1.html Title: c Moz"
[task 2023-08-01T03:10:00.964Z] 03:10:00     INFO -  "result: http://foo.mail.com/changeme1.html Title: c Moz"
[task 2023-08-01T03:10:00.964Z] 03:10:00     INFO -  "result: http://foo.mail.com/changeme1.html Title: c Moz"
[task 2023-08-01T03:10:00.964Z] 03:10:00     INFO -  "result: http://foo.mail.com/changeme1.html Title: c Moz"
[task 2023-08-01T03:10:00.965Z] 03:10:00     INFO -  "result: http://foo.mail.com/changeme1.html Title: c Moz"
[task 2023-08-01T03:10:00.965Z] 03:10:00     INFO -  "Comparing Array to Results"
[task 2023-08-01T03:10:00.965Z] 03:10:00     INFO -  TEST-PASS | toolkit/components/places/tests/queries/test_results-as-visit.js | test_results_as_visit - [test_results_as_visit : 95] 15 == 15
[task 2023-08-01T03:10:00.966Z] 03:10:00     INFO -  "testing testData[http://foo.com/] vs result[http://foo.com/]"
[task 2023-08-01T03:10:00.966Z] 03:10:00     INFO -  "testing testData[http://foo.com/] vs result[http://foo.com/]"
[task 2023-08-01T03:10:00.967Z] 03:10:00     INFO -  "testing testData[http://foo.com/] vs result[http://foo.com/]"
[task 2023-08-01T03:10:00.967Z] 03:10:00     INFO -  "testing testData[http://moilla.com/] vs result[http://moilla.com/]"
[task 2023-08-01T03:10:00.968Z] 03:10:00     INFO -  "testing testData[http://moilla.com/] vs result[http://moilla.com/]"
[task 2023-08-01T03:10:00.970Z] 03:10:00     INFO -  "testing testData[http://moilla.com/] vs result[http://moilla.com/]"
[task 2023-08-01T03:10:00.970Z] 03:10:00     INFO -  "testing testData[http://moilla.com/] vs result[http://moilla.com/]"
[task 2023-08-01T03:10:00.970Z] 03:10:00     INFO -  "testing testData[http://moilla.com/] vs result[http://moilla.com/]"
[task 2023-08-01T03:10:00.971Z] 03:10:00     INFO -  "testing testData[http://foo.mail.com/changeme1.html] vs result[http://foo.mail.com/changeme1.html]"
[task 2023-08-01T03:10:00.971Z] 03:10:00     INFO -  "testing testData[http://foo.mail.com/changeme1.html] vs result[http://foo.mail.com/changeme1.html]"
[task 2023-08-01T03:10:00.972Z] 03:10:00     INFO -  "testing testData[http://foo.mail.com/changeme1.html] vs result[http://foo.mail.com/changeme1.html]"
[task 2023-08-01T03:10:00.972Z] 03:10:00     INFO -  "testing testData[http://foo.mail.com/changeme1.html] vs result[http://foo.mail.com/changeme1.html]"
[task 2023-08-01T03:10:00.973Z] 03:10:00     INFO -  "testing testData[http://foo.mail.com/changeme1.html] vs result[http://foo.mail.com/changeme1.html]"
[task 2023-08-01T03:10:00.973Z] 03:10:00     INFO -  "testing testData[http://foo.mail.com/changeme1.html] vs result[http://foo.mail.com/changeme1.html]"
[task 2023-08-01T03:10:00.973Z] 03:10:00     INFO -  "testing testData[http://foo.mail.com/changeme1.html] vs result[http://foo.mail.com/changeme1.html]"
[task 2023-08-01T03:10:00.973Z] 03:10:00     INFO -  "Comparing Array to Results passes"
[task 2023-08-01T03:10:00.973Z] 03:10:00     INFO -  "Adding item to query"
[task 2023-08-01T03:10:00.974Z] 03:10:00     INFO -  TEST-PASS | toolkit/components/places/tests/queries/test_results-as-visit.js | test_results_as_visit - [test_results_as_visit : 110] "ab moz" == "ab moz"
[task 2023-08-01T03:10:00.974Z] 03:10:00     INFO -  TEST-PASS | toolkit/components/places/tests/queries/test_results-as-visit.js | test_results_as_visit - [test_results_as_visit : 110] "ab moz" == "ab moz"
[task 2023-08-01T03:10:00.975Z] 03:10:00     INFO -  "Updating Item"
[task 2023-08-01T03:10:00.975Z] 03:10:00     INFO -  TEST-PASS | toolkit/components/places/tests/queries/test_results-as-visit.js | test_results_as_visit - [test_results_as_visit : 119] true == true
[task 2023-08-01T03:10:00.975Z] 03:10:00     INFO -  "Updating More Items"
[task 2023-08-01T03:10:00.976Z] 03:10:00     INFO -  TEST-PASS | toolkit/components/places/tests/queries/test_results-as-visit.js | test_results_as_visit - [test_results_as_visit : 141] true == true
[task 2023-08-01T03:10:00.976Z] 03:10:00     INFO -  TEST-PASS | toolkit/components/places/tests/queries/test_results-as-visit.js | test_results_as_visit - [test_results_as_visit : 142] true == true
[task 2023-08-01T03:10:00.977Z] 03:10:00     INFO -  "Delete item outside of batch"
[task 2023-08-01T03:10:00.977Z] 03:10:00     INFO -  PID 28246 | =================================================================
[task 2023-08-01T03:10:00.978Z] 03:10:00    ERROR -  PID 28246 | ==28246==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffc0828b4f4 at pc 0x7ff66aba5cfd bp 0x7ffc0828b090 sp 0x7ffc0828b088
[task 2023-08-01T03:10:00.978Z] 03:10:00     INFO -  PID 28246 | READ of size 1 at 0x7ffc0828b4f4 thread T0
[task 2023-08-01T03:10:00.979Z] 03:10:00     INFO -  PID 28246 |     #0 0x7ff66aba5cfc in nsTCharSeparatedTokenizer<nsTDependentSubstring<char>, &NS_TokenizerIgnoreNothing(char16_t), (nsTokenizerFlags)2>::nextToken() /builds/worker/workspace/obj-build/dist/include/nsCharSeparatedTokenizer.h:119:28
[task 2023-08-01T03:10:00.979Z] 03:10:00     INFO -  PID 28246 |     #1 0x7ff66aba5437 in nsTokenizedRange<nsTCharSeparatedTokenizer<nsTDependentSubstring<char>, &NS_TokenizerIgnoreNothing(char16_t), (nsTokenizerFlags)2>>::Iterator::Next() /builds/worker/workspace/obj-build/dist/include/nsCharSeparatedTokenizer.h:236:42
[task 2023-08-01T03:10:00.979Z] 03:10:00     INFO -  PID 28246 |     #2 0x7ff67a7c9f8e in Iterator /builds/worker/workspace/obj-build/dist/include/nsCharSeparatedTokenizer.h:215:7
[task 2023-08-01T03:10:00.979Z] 03:10:00     INFO -  PID 28246 |     #3 0x7ff67a7c9f8e in begin /builds/worker/workspace/obj-build/dist/include/nsCharSeparatedTokenizer.h:244:31
[task 2023-08-01T03:10:00.980Z] 03:10:00     INFO -  PID 28246 |     #4 0x7ff67a7c9f8e in (anonymous namespace)::isQuerySearchTermsMatching(RefPtr<nsNavHistoryQuery> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char16_t> const&) /builds/worker/checkouts/gecko/toolkit/components/places/nsNavHistoryResult.cpp:295:30
[task 2023-08-01T03:10:00.980Z] 03:10:00     INFO -  PID 28246 |     #5 0x7ff67a7c913f in isQuerySearchTermsMatching /builds/worker/checkouts/gecko/toolkit/components/places/nsNavHistoryResult.cpp:305:10
[task 2023-08-01T03:10:00.980Z] 03:10:00     INFO -  PID 28246 |     #6 0x7ff67a7c913f in nsNavHistoryQueryResultNode::OnTitleChanged(nsIURI*, nsTSubstring<char16_t> const&, nsTSubstring<char> const&) /builds/worker/checkouts/gecko/toolkit/components/places/nsNavHistoryResult.cpp:2334:12
[task 2023-08-01T03:10:00.980Z] 03:10:00     INFO -  PID 28246 |     #7 0x7ff67a7e4ba4 in nsNavHistoryResult::HandlePlacesEvent(mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::dom::PlacesEvent>> const&) /builds/worker/checkouts/gecko/toolkit/components/places/nsNavHistoryResult.cpp:4404:9
[task 2023-08-01T03:10:00.981Z] 03:10:00     INFO -  PID 28246 |     #8 0x7ff66e33ae48 in operator() /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_function.h:687:14
[task 2023-08-01T03:10:00.982Z] 03:10:00     INFO -  PID 28246 |     #9 0x7ff66e33ae48 in void mozilla::dom::CallListeners<mozilla::WeakPtr<mozilla::places::INativePlacesEventCallback, (mozilla::detail::WeakPtrDestructorBehavior)0>, RefPtr<mozilla::places::INativePlacesEventCallback>, mozilla::dom::ListenerCollection<mozilla::WeakPtr<mozilla::places::INativePlacesEventCallback, (mozilla::detail::WeakPtrDestructorBehavior)0>>>(unsigned int, mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::dom::PlacesEvent>> const&, unsigned long, std::function<RefPtr<mozilla::places::INativePlacesEventCallback> (mozilla::WeakPtr<mozilla::places::INativePlacesEventCallback, (mozilla::detail::WeakPtrDestructorBehavior)0>&)> const&, std::function<void (RefPtr<mozilla::places::INativePlacesEventCallback>&, mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::dom::PlacesEvent>> const&)> const&) /builds/worker/checkouts/gecko/dom/base/PlacesObservers.cpp:112:7
[task 2023-08-01T03:10:00.982Z] 03:10:00     INFO -  PID 28246 |     #10 0x7ff66e33958c in mozilla::dom::PlacesObservers::NotifyNext() /builds/worker/checkouts/gecko/dom/base/PlacesObservers.cpp:350:3
[task 2023-08-01T03:10:00.983Z] 03:10:00     INFO -  PID 28246 |     #11 0x7ff67a7fba19 in mozilla::places::NotifyManyVisitsObservers::Run() /builds/worker/checkouts/gecko/toolkit/components/places/History.cpp:596:7
[task 2023-08-01T03:10:00.984Z] 03:10:00     INFO -  PID 28246 |     #12 0x7ff66a98575a in mozilla::RunnableTask::Run() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:559:16
[task 2023-08-01T03:10:00.985Z] 03:10:00     INFO -  PID 28246 |     #13 0x7ff66a971c78 in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:886:26
[task 2023-08-01T03:10:00.985Z] 03:10:00     INFO -  PID 28246 |     #14 0x7ff66a96e687 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:709:15
[task 2023-08-01T03:10:00.986Z] 03:10:00     INFO -  PID 28246 |     #15 0x7ff66a96ef69 in mozilla::TaskController::ProcessPendingMTTask(bool) /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:495:36
[task 2023-08-01T03:10:00.987Z] 03:10:00     INFO -  PID 28246 |     #16 0x7ff66a98d234 in operator() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:221:37
[task 2023-08-01T03:10:00.988Z] 03:10:00     INFO -  PID 28246 |     #17 0x7ff66a98d234 in mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_1>::Run() /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.h:548:5
[task 2023-08-01T03:10:00.988Z] 03:10:00     INFO -  PID 28246 |     #18 0x7ff66a9b77e3 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1199:16
[task 2023-08-01T03:10:00.989Z] 03:10:00     INFO -  PID 28246 |     #19 0x7ff66a9c4561 in NS_ProcessNextEvent /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:480:10
[task 2023-08-01T03:10:00.990Z] 03:10:00     INFO -  PID 28246 |     #20 0x7ff66a9c4561 in SpinEventLoopUntil<(mozilla::ProcessFailureBehavior)1, (lambda at /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:655:61)> /builds/worker/workspace/obj-build/dist/include/mozilla/SpinEventLoopUntil.h:176:25
[task 2023-08-01T03:10:00.991Z] 03:10:00     INFO -  PID 28246 |     #21 0x7ff66a9c4561 in nsThreadManager::SpinEventLoopUntilInternal(nsTSubstring<char> const&, nsINestedEventLoopCondition*, mozilla::ShutdownPhase) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:655:8
[task 2023-08-01T03:10:00.991Z] 03:10:00     INFO -  PID 28246 |     #22 0x7ff66aa0efd5 in NS_InvokeByIndex /builds/worker/checkouts/gecko/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S:101
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #23 0x7ff66c76f266 in Invoke /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1627:10
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #24 0x7ff66c76f266 in Call /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1180:19
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #25 0x7ff66c76f266 in XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNative.cpp:1126:23
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #26 0x7ff66c774d46 in XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:966:10
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #27 0x7ff67b13ec3f in CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:486:13
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #28 0x7ff67b13ec3f in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:580:12
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #29 0x7ff67b1638a5 in InternalCall /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:647:10
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #30 0x7ff67b1638a5 in CallFromStack /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:652:10
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #31 0x7ff67b1638a5 in js::Interpret(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:3395:16
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #32 0x7ff67b13d9eb in MaybeEnterInterpreterTrampoline /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:400:10
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #33 0x7ff67b13d9eb in js::RunScript(JSContext*, js::RunState&) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:458:13
[task 2023-08-01T03:10:00.992Z] 03:10:00     INFO -  PID 28246 |     #34 0x7ff67b13edf5 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:612:13
[task 2023-08-01T03:10:00.993Z] 03:10:00     INFO -  PID 28246 |     #35 0x7ff67c2c2279 in js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICFallbackStub*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) /builds/worker/checkouts/gecko/js/src/jit/BaselineIC.cpp:1648:10
[task 2023-08-01T03:10:00.993Z] 03:10:00     INFO -  PID 28246 |     #36 0x2bb681655f5b  (<unknown module>)
[task 2023-08-01T03:10:00.993Z] 03:10:00     INFO -  PID 28246 | Address 0x7ffc0828b4f4 is located in stack of thread T0 at offset 756 in frame

Flags: needinfo?(daisuke)

Pulsebot

Comment 5

•

1 year ago

Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afe663873f07 Stop using URIToResultNode() r=mak

Cristian Tuns

Comment 6

•

1 year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/afe663873f07

Status: ASSIGNED → RESOLVED

Closed: 1 year ago

status-firefox118: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 118 Branch

Mark Banner (:standard8)

Updated

•

1 year ago

Flags: needinfo?(daisuke)

Bug 1829581: Stop using URIToResultNode() 1 year ago Daisuke Akatsuka (:daisuke) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1829581: Stop using URIToResultNode() in OnItemTagsChanged() 1 year ago Daisuke Akatsuka (:daisuke) 48 bytes, text/x-phabricator-request		Details \| Review

Bugzilla

Remove nsNavHistory::URIToResultNode()

Categories

(Toolkit :: Places, task, P3)

Tracking

()

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file, 1 obsolete file)

Description

Updated

Updated

Comment 1

Updated

Comment 2

Updated

Updated

Updated

Updated

Updated

Updated

Comment 3

Comment 4

Comment 5

Comment 6

Updated

Attachment

General

Description

File Name

Content Type