1829583 - Revert to lookbehind syntax once supported on iOS

Status: ASSIGNED

(Toolkit :: Form Autofill, task, P5)

Description

[Issam Mani [:issammani]]

In order to support webkit, we need to avoid usage of negative lookbehind due to low support. The first safari version with support is 16.4 (Release Date: 27th March 2023). The workaround to mimic the behaviour of negative lookbehinds is using a named capture group (?<!not)word -> (?<neg>notword)|word.

Comment 1

[Issam Mani [:issammani]]

Attachment: Bug 1829583 - Revert to using negative lookbehind syntax. r=dimi!

Comment 2

[Issam Mani [:issammani]]

Update on this. We will need to wait until the min supported iOS version in Firefox is 16. Right now this is still 15.

From slack:

Hard to say. Our general strategy has been to support 2 versions older than the current one, but this next release will be a little different than previous ones because it's going to impact a lot more users than previous releases.
Once we get closer to the release of iOS 18 I'll put together a document with the pros and cons of continuing to support iOS 15 and then it will be a product decisions of if we drop support or not.
If we do drop support then it will happen sometime around September/October.

Comment 3

[Issam Mani [:issammani]]

I will keep the patch as WIP for whenever we are ready to do this.