Closed Bug 1829688 Opened 1 year ago Closed 1 year ago

Don't always select original source on pause

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox114 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [devtools:relnote])

Attachments

(2 files)

For now, when we pause, the debugger frontend would always force selecting the original source. That, even if we were previously selecting a generated file.
This goes against the overall goal being done elsewhere to "keep context", and select the same type of source as the currently selected one (original if original is selected, or generatd otherwise).

We could still try to open the original source if no source is currently selected,
but when a source is already selected, try to keep the same context.

Instead, if we were selecting a generated source, we would keep selecting generated source.
If there is no selected source, we would still try to select the original source.

Many tests were relying on this behavior.

WASM test was failing because of errors with the parser worker.
I added early bailout in order to prevent trying to use the parser worker for WASM.

shared-head test helper were also tweaked to better support select WASM binary sources.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Blocks: 1829860

The worker itself ignores already the WASM sources,
but we could save some cycle to avoid calling the parserWorker entirely
when we know the source won't be supported by it.

Severity: -- → S3
Priority: -- → P3
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81fb6fc69cca
[devtools] Avoid querying the parser worker for unsupported sources. r=nchevobbe,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/bb12f557adeb
[devtools] Avoid selecting the original source everytime we hit a breakpoint. r=devtools-reviewers,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
See Also: → 1634721

Alongside bug 1634721 this improved stepping through original files and regular js modules. You context will be better preserved.

Whiteboard: [devtools:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: