1829744 - Links to generated source in debugger's editor's footer doesn't work

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Alexandre Poirot [:ochameau]]

STR:

• open any page with an original source
  For example: http://techno-barje.fr/fission/sourcemap/
• select this original source
  Example here, webpack > xhr_original.js
• click on "(From xhr_bundle.js)" in the bottom right under the code editor

AR: No source is displayed, instead, the debugger shows the homepage with key shortcuts

ER: the xhr_xundle.js source is shown

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1829744 - [devtools] Fix jumping to generated location from editor's footer.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1815500

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd379235f7bf
[devtools] Fix jumping to generated location from editor's footer. r=devtools-reviewers,nchevobbe

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fd379235f7bf

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ochameau, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 9330044 [details]
Bug 1829744 - [devtools] Fix jumping to generated location from editor's footer.

Beta/Release Uplift Approval Request

• User impact if declined: The links to generated sources is broken (bottom right of debugger code editor when opening an original file)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch only impacts the debugger and fix a small miss in a previous refactoring.
• String changes made/needed: no
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9330044 [details]
Bug 1829744 - [devtools] Fix jumping to generated location from editor's footer.

Approved for 113.0b9.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ab007da0f79a

Comment 9

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64, macOS 11.6 and Ubuntu 20.04 x64.

Comment 10

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 113.0b9 on Windows 10 x64, macOS 11.6 and on Ubuntu 20.04 x64.