1829800 - MDNCompatibility#getCSSDeclarationBlockIssues could be faster

Status: RESOLVED FIXED

(DevTools :: Inspector: Compatibility, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

• we're using spread operator when calling functions and then rest operator in the function arg, creating unnecessary intermediary arrays
• a single call to _getCompatSummary will result in 4 calls to _getCompatTable, when we can probably do a single one

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1829800 - [devtools] Improve performance of MDNCompatibility methods. r=jdescottes.

In _getCompatSummary, we were indirectly calling getCompatTable multiple times
with the same parameters. We fix this by calling it once directly in _getCompatSummary,
and then looking into the result to extract the data we want.

This patch also removes unecessary spread/rest operators when we didn't get any
values from it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d6c43afb41b
[devtools] Improve performance of MDNCompatibility methods. r=jdescottes,devtools-reviewers.

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8d6c43afb41b