1829801 - Rule#getCompatibilityIssues guard isn't efficient

Status: RESOLVED FIXED

(DevTools :: Inspector: Compatibility, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

https://searchfox.org/mozilla-central/rev/26790fecfcda622dab234b28859da721b80f3a35/devtools/client/inspector/rules/models/rule.js#216-230

async getCompatibilityIssues() {
  if (!this.compatibilityIssues) {
    const [targetBrowsers, compatibility] = await Promise.all([
      getTargetBrowsers(),
      this.inspector.inspectorFront.getCompatibilityFront(),
    ]);

    this.compatibilityIssues = await compatibility.getCSSDeclarationBlockIssues(
      this.domRule.declarations,
      targetBrowsers
    );
  }

  return this.compatibilityIssues;
}

This function is called for each property in a rule.
The intent is to only retrieve the browsers, the compatibility front, and then the compat issues if it wasn't done before
But here, since we set this.compatibilityIssues after retrieving the browsers and the front, multiple "concurrent" call will probably end up calling getCSSDeclarationBlockIssues

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1829801 - [devtools] Fix Rule#getCompatibilityIssues guard. r=jdescottes.

This patch sets this.compatibilityIssues earlier so we effectively guard on
multiple "concurrent" calls.

Depends on D176395

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5fd7e54df34
[devtools] Fix Rule#getCompatibilityIssues guard. r=jdescottes,devtools-reviewers.

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f5fd7e54df34