1829874 - Disabled fieldset should not stop event propagation

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Daniel Turan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0

Steps to reproduce:

This is the same bug, that I has been fixed in chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1422547

(1) open the codepen: https://jsfiddle.net/vxr45h3c/
(2) click RUN
(3) click disabled - click me

Actual results:

Nothing - no alert is shown.

Expected results:

The event should be propagated up to the document -> alert should be show.

Fieldset elements themselves aren't actually supposed to be disabled
form controls, they are just supposed to make their descendant field
control elements disabled:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-fe-disabled

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Events' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Looks Kagami has been on this issue already.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

I think I'll wait until it reaches the Chrome stable channel to see if the approach is web compatible. I hope that makes sense.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Putting this in my dashboard btw.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

S2 because it blocks another S2.

Comment 6

[Daniel Turan]

@K(In reply to Kagami [:saschanaz] from comment #3)

I think I'll wait until it reaches the Chrome stable channel to see if the approach is web compatible. I hope that makes sense.

I reported this to Chromium as soon as they have broken it recently in stable channel. The requested behavior is original behavior of chromium, so it is "Web compatible"

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

The thing is that Blink is experimenting to change their general disabled form element behavior. If they decide the whole approach is not web-compatible then we'll need to discuss more and may need to implement some other approach. So I'd like to see the conclusion before doing something here.

That said, I think fixing this specific issue would be simple enough and probably shouldn't be affected even if we decide to try some other approach. A patch will be welcome.

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

At this point both WebKit TP and Chrome stable have this, we can make the change with reasonable confidence.

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1829874 - Allow events on disabled fieldsets r=edgar

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/487a29bd817e
Allow events on disabled fieldsets r=edgar

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40520 for changes under testing/web-platform/tests

Comment 12

[Cosmin Sabou [:CosminS]]

Backed out for fieldset related mochitest failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=487a29bd817e095a738365045f74b84e5efaf72c&selectedTaskRun=U6c-1_hKRYS3_srw011Vvw.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=419118898&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=419119290&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/f883b9662835d8b740f8ae5174e3c4a82ab448f3

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbc03cb5c0eb
Allow events on disabled fieldsets r=edgar

Comment 15

[Kagami Rosylight [:saschanaz] (they/them)]

Oh no, forgot to enable dom.forms.fieldset_disable_only_descendants.enabled for tests to prevent beta simulation failure.

Comment 16

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1829874 - Add prefs for tests r=edgar

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdbd72f04035
Add prefs for tests r=edgar

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fbc03cb5c0eb
https://hg.mozilla.org/mozilla-central/rev/bdbd72f04035

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot