1829982 - Refactor Push to align with Application Services push refactor

Status: RESOLVED FIXED

(Firefox for Android :: Push, enhancement)

Description

[Tarik Eshaq [:teshaq]]

This is a ticket for myself to prepare Fenix changes needed for an application services refactor in https://github.com/mozilla/application-services/pull/5389

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1829982: Fixes push breaking changes for AS (#1780)

Comment 2

[BMO Github Automation]

Authored by https://github.com/tarikeshaq
https://github.com/mozilla-mobile/firefox-android/commit/5d2ad852caed07a61468977c7d2d420f851f1171
[main] Bug 1829982: Fixes push breaking changes for AS

Comment 3

[Tarik Eshaq [:teshaq]]

To verify this works as expected:

• Test send tab by doing the following:
  • Sign in to the same Firefox Account on both Android (a build with the patch landed) and another device
  • Send a tab from the other device to Firefox on Android and verify a push notification arrives
• Test web push on a web app
  • Go to a website that uses webpush to send push notifications, for example: https://simple-push-demo.vercel.app/
  • Send yourself a push notification from that site, and verify that the push notification arrives

Comment 4

[Adina Petridean QA [:apetridean]]

Thank you Tarik!
Verified as fixed that the push notification is received when sending a push notification from a website (https://web-push-book.gauntface.com/demos/notification-examples/) and when sending a tab to an Android device.

Tested on the latest Fenix Nightly 115.0a1 from 6/02 with the following devices:
Motorola Moto G9 plus (Android 11)
Samsung GalaxyZ Fold 4 (Android 13)

Comment 5

[Adina Petridean QA [:apetridean]]

Attachment: pushNotification.mp4